From: Giuseppe CAVALLARO <peppe.cavallaro@st•com>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org
Subject: Re: [net-next 2/2] stmmac: add mixed burst for DMA
Date: Mon, 14 May 2012 09:22:20 +0200 [thread overview]
Message-ID: <4FB0B2AC.5070903@st.com> (raw)
In-Reply-To: <20120511.181259.845221725995971870.davem@davemloft.net>
On 5/12/2012 12:12 AM, David Miller wrote:
> From: Giuseppe CAVALLARO <peppe.cavallaro@st•com>
> Date: Mon, 7 May 2012 11:12:33 +0200
>
>> - int (*init) (void __iomem *ioaddr, int pbl, int fb, int burst_len,
>> - u32 dma_tx, u32 dma_rx);
>> + int (*init) (void __iomem *ioaddr, int pbl, int fb, int mb,
>> + int burst_len, u32 dma_tx, u32 dma_rx);
>
> Fix the indentation of the arguments on the second line,
> the first character must line up with the first column after
> the function's openning parenthesis on the previous line.
Yes, my fault and fixed at once.
>
>> -static int dwmac1000_dma_init(void __iomem *ioaddr, int pbl, int fb,
>> +static int dwmac1000_dma_init(void __iomem *ioaddr, int pbl, int fb, int mb,
>> int burst_len, u32 dma_tx, u32 dma_rx)
>
> While you're here fix up that issue in the existing code here as well.
>
>> -static int dwmac100_dma_init(void __iomem *ioaddr, int pbl, int fb,
>> +static int dwmac100_dma_init(void __iomem *ioaddr, int pbl, int fb, int mb,
>> int burst_len, u32 dma_tx, u32 dma_rx)
>
> Likewise.
After applying the patch the argument "int burst_len" is aligned with
the first column after the opening parenthesis.
Anyway I've just re-looked at the code and verified that.
>
>> - int pbl = DEFAULT_DMA_PBL, fixed_burst = 0, burst_len = 0;
>> + int pbl = DEFAULT_DMA_PBL, fixed_burst = 0, burst_len = 0,
>> + mixed_burst = 0;
>
> This is gross, just make a new "int" declaration for mixed_burst.
fixed :-(
I'm resending the patches now.
Thanks for your review and sorry for these kind of errors.
peppe
>
>
>
next prev parent reply other threads:[~2012-05-14 7:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 9:12 [net-next 1/2] stmmac: extend mac addr reg and fix perfect filering Giuseppe CAVALLARO
2012-05-07 9:12 ` [net-next 2/2] stmmac: add mixed burst for DMA Giuseppe CAVALLARO
2012-05-11 22:12 ` David Miller
2012-05-14 7:22 ` Giuseppe CAVALLARO [this message]
2012-05-11 22:11 ` [net-next 1/2] stmmac: extend mac addr reg and fix perfect filering David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB0B2AC.5070903@st.com \
--to=peppe.cavallaro@st$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox