From: Stuart Hodgson <smhodgson@solarflare•com>
To: Ben Hutchings <bhutchings@solarflare•com>
Cc: Yaniv Rosner <yanivr@broadcom•com>,
David Miller <davem@davemloft•net>, <netdev@vger•kernel.org>,
Eilon Greenstein <eilong@broadcom•com>
Subject: Re: [PATCH ethtool] Add command to dump module EEPROM
Date: Mon, 14 May 2012 16:36:30 +0100 [thread overview]
Message-ID: <4FB1267E.2090006@solarflare.com> (raw)
In-Reply-To: <1337005139.2550.6.camel@bwh-desktop.uk.solarflarecom.com>
On 14/05/12 15:18, Ben Hutchings wrote:
> On Mon, 2012-05-14 at 18:13 +0300, Yaniv Rosner wrote:
>> Hi Ben,
>> This patch adds a new option to dump (SFP+, XFP, ...) module EEPROM following
>> recent support to kernel side. Below some examples:
>>
>> bash-3.00# ethtool -m eth1 offset 0x14 length 32 raw on
>> JDSU PLRXPLSCS432
>>
>> bash-3.00# ethtool -m eth1 offset 0x14 length 32
>> Offset Values
>> ------ ------
>> 0x0014 4a 44 53 55 20 20 20 20 20 20 20 20 20 20 20 20
>> 0x0024 00 00 01 9c 50 4c 52 58 50 4c 53 43 53 34 33 32
>>
>> Please consider applying to ethtool.
>
> I agree there should be ASCII-hex and binary dump modes, but we should
> also support decoding of recognised EEPROM types (as Stuart proposed
> earlier).
I have a patch to do this as well, but also parse the SFP+ EEPROM.
I need to fix it up after some of the changes to the patches that added
kernel support but can submit in the next day or so if this would be of
use.
Stu
next prev parent reply other threads:[~2012-05-14 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 15:13 [PATCH ethtool] Add command to dump module EEPROM Yaniv Rosner
2012-05-14 14:18 ` Ben Hutchings
2012-05-14 15:36 ` Stuart Hodgson [this message]
2012-05-14 18:57 ` Yaniv Rosner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB1267E.2090006@solarflare.com \
--to=smhodgson@solarflare$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eilong@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=yanivr@broadcom$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox