Subject: Re: [PATCH net-next 1/8] net/mlx4: Address build warnings on set but not used variables

From: Or Gerlitz <[email-masked]>
Date: Tue, 15 May 2012 08:52:06 +0300

On 5/15/2012 7:07 AM, David Miller wrote:
>
>> -		err = mlx4_qp_detach_common(dev,&qp, rgid->gid, rgid->prot,
>> +		(void) mlx4_qp_detach_common(dev,&qp, rgid->gid, rgid->prot,
>>   					    rgid->steer);
>
> You must update the indentation of all the lines comprising of the function call when you change the indentation of it's initial line.

Just want to make sure I understood right what has to be done here, e.g 
in this case its needs to be
like this?

> @@ -2604,13 +2604,12 @@ static void detach_qp(struct mlx4_dev *dev, 
> int slave, struct res_qp *rqp)
>  {
>         struct res_gid *rgid;
>         struct res_gid *tmp;
> -       int err;
>         struct mlx4_qp qp; /* dummy for calling attach/detach */
>
>         list_for_each_entry_safe(rgid, tmp, &rqp->mcg_list, list) {
>                 qp.qpn = rqp->local_qpn;
> -               err = mlx4_qp_detach_common(dev, &qp, rgid->gid, 
> rgid->prot,
> -                                           rgid->steer);
> +               (void) mlx4_qp_detach_common(dev, &qp, rgid->gid, 
> rgid->prot,
> +                                                   rgid->steer);
>                 list_del(&rgid->list);
>                 kfree(rgid);
>         }

Or.