Subject: Re: [PATCH 3/8] mISDN: avmfritz use the bigger fifo of chip version 2

From: Karsten Keil <[email-masked]>
Date: Wed, 16 May 2012 09:00:11 +0200

Am 16.05.2012 07:16, schrieb David Miller:
> From: Karsten Keil<[email-masked]>
> Date: Wed, 16 May 2012 06:22:49 +0200
>
>> +	mode = (AVM_FRITZ_PCIV2 == fc->type) ? HDLC_FIFO_SIZE_128 : 0;
>
> Please don't do this "CONSTANT == variable" type testing order, it's
> completely unnatural and not something we commonly do elsewhere in the
> networking code.
>

I fully agree, looks much better.

> I know some coders bible somewhere says that this is how you avoid
> accidental assignments, but it's too ugly to live.

With todays compilers as long you do not disable/ignore warnings it 
should be safe as well.

Will send version 2 of the patchset soon (with all other issues fixed too)

Karsten