public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Jan Ceuleers <jan.ceuleers@computer•org>
To: Joe Perches <joe@perches•com>
Cc: David Miller <davem@davemloft•net>,
	b06378@freescale•com, netdev@vger•kernel.org,
	linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH] gianfar:don't add FCB length to hard_header_len
Date: Thu, 24 May 2012 20:03:13 +0200	[thread overview]
Message-ID: <4FBE77E1.4010103@computer.org> (raw)
In-Reply-To: <1337876210.5070.4.camel@joe2Laptop>

On 05/24/2012 06:16 PM, Joe Perches wrote:
> On Thu, 2012-05-24 at 17:04 +0200, Jan Ceuleers wrote:
>> On 05/22/2012 09:18 PM, David Miller wrote:
>>> Someone needs to go through this driver when net-next opens up
>>> and fix all of the indentation in this driver.
>>
>> May I give that a go?
> 
> I have scripts that automate most of this.
> I don't have the card though.
> 
> Maybe this is a starting point?
> It doesn't fix most 80 column warnings.

Thanks Joe.

I also don't have the card; the kinds of changes I was proposing to make
are code-neutral, whose correctness I was intending to prove by a binary
compare of the before-and-after .o.

Still happy to do that taking your contribution as a starting point.

Thanks, Jan

next prev parent reply	other threads:[~2012-05-24 18:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-22  9:00 [PATCH] gianfar:don't add FCB length to hard_header_len Jiajun Wu
2012-05-22 19:18 ` David Miller
2012-05-24 15:04   ` Jan Ceuleers
2012-05-24 16:16     ` Joe Perches
2012-05-24 18:03       ` Jan Ceuleers [this message]
2012-05-25 15:58       ` Paul Gortmaker
2012-05-25 19:51         ` Joe Perches
2012-05-25 20:04           ` Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBE77E1.4010103@computer.org \
    --to=jan.ceuleers@computer$(echo .)org \
    --cc=b06378@freescale$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=joe@perches$(echo .)com \
    --cc=linuxppc-dev@lists$(echo .)ozlabs.org \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox