From: Boaz Harrosh <bharrosh-C4P08NqkoRlBDgjK7y7TUQ@public•gmane.org>
To: Peng Tao <bergwolf-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>
Cc: Trond Myklebust
<Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public•gmane.org>,
"J. Bruce Fields"
<bfields-uC3wQj2KruNg9hUCZPvPmw@public•gmane.org>,
<tao.peng-mb1K0bWo544@public•gmane.org>,
<skinsbursky-bzQdu9zFT3WakBO8gow8eQ@public•gmane.org>,
<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
<xemul-bzQdu9zFT3WakBO8gow8eQ@public•gmane.org>,
<neilb-l3A5Bk7waGM@public•gmane.org>,
<netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
<jbottomley-bzQdu9zFT3WakBO8gow8eQ@public•gmane.org>,
<davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org>,
<devel-GEFAQzZX7r8dnm+yROfE0A@public•gmane.org>,
Steve Dickson <steved-H+wXaHxf7aLQT0dZR+AlfA@public•gmane.org>
Subject: Re: [PATCH 4/5] NFS: remove RPC PipeFS mount point reference from blocklayout routines
Date: Mon, 28 May 2012 14:43:53 +0300 [thread overview]
Message-ID: <4FC364F9.4090308@panasas.com> (raw)
In-Reply-To: <CA+a=Yy4bEKaeUihjYLRzXVbjA3fc2EuZ3ToAkf0w-oL3PnZJKQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 11/29/2011 07:30 PM, Peng Tao wrote:
> On Wed, Nov 30, 2011 at 1:19 AM, Trond Myklebust
> <Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public•gmane.org> wrote:
>> On Tue, 2011-11-29 at 11:42 -0500, J. Bruce Fields wrote:
>>> On Tue, Nov 29, 2011 at 11:40:30AM -0500, Trond Myklebust wrote:
>>>> I mean that I'm perfectly entitled to do
>>>>
>>>> 'modprobe -r blocklayoutdriver'
>>>>
>>>> and when I do that, then I expect blkmapd to close the rpc pipe and wait
>>>> for a new one to be created just like rpc.idmapd and rpc.gssd do when I
>>>> remove the nfs and sunrpc modules.
>>>
>>> The rpc pipefs mount doesn't hold a reference on the sunrpc module?
>>
>> I stand corrected: the mount does hold a reference to the sunrpc
>> module.
>> However nothing holds a reference to the blocklayoutdriver module, so
>> the main point that the "blocklayout" pipe can disappear from underneath
>> the blkmapd stands.
> Thanks for the explanation and I agree it can cause problem if user
> reload blocklayout module. I will look into a fix to blkmapd.
>
You might want to consider converting to call_usermodehelper()
I know that it greatly simplified our code both in Kernel and
in user-mode. And it made nfs-utils maintainer much happier
as well.
The speed is not Cardinal here I think. Like in objects it's
done once per new device_id
> Best,
> Tao
Just my $0.017
Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-05-28 11:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 10:10 [PATCH 0/5] NFS: create blocklayout pipe per network namesapce context Stanislav Kinsbursky
2011-11-29 9:17 ` Stanislav Kinsbursky
2011-11-29 10:10 ` [PATCH 1/5] NFS: handle blocklayout pipe PipeFS dentry by network namespace aware routines Stanislav Kinsbursky
2011-11-29 10:10 ` [PATCH 2/5] NFS: blocklayout pipe creation per network namespace context introduced Stanislav Kinsbursky
[not found] ` <20111129090754.20730.64567.stgit-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
2011-11-29 10:10 ` [PATCH 3/5] NFS: blocklayout PipeFS notifier introduced Stanislav Kinsbursky
2011-12-30 22:55 ` [PATCH 0/5] NFS: create blocklayout pipe per network namesapce context Trond Myklebust
2012-01-05 20:58 ` Trond Myklebust
2012-01-10 12:58 ` Stanislav Kinsbursky
[not found] ` <4F0C35F3.7060508-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-01-11 16:23 ` Trond Myklebust
2012-01-11 17:23 ` Stanislav Kinsbursky
[not found] ` <4F0DC582.6030805-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-01-11 17:46 ` Trond Myklebust
2012-01-11 18:03 ` Stanislav Kinsbursky
2012-01-10 10:50 ` Stanislav Kinsbursky
2011-11-29 10:10 ` [PATCH 4/5] NFS: remove RPC PipeFS mount point reference from blocklayout routines Stanislav Kinsbursky
[not found] ` <20111129091037.20730.59391.stgit-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
2011-11-29 12:00 ` tao.peng-mb1K0bWo544
2011-11-29 12:19 ` Stanislav Kinsbursky
[not found] ` <4ED4CDCE.9080804-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2011-11-29 12:40 ` tao.peng-mb1K0bWo544
2011-11-29 13:13 ` Stanislav Kinsbursky
[not found] ` <4ED4DA80.9080303-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2011-11-29 15:05 ` Peng Tao
2011-11-29 13:35 ` Myklebust, Trond
[not found] ` <2E1EB2CF9ED1CB4AA966F0EB76EAB4430C3CBC23-hX7t0kiaRRrlMGe9HJ1VYQK/GNPrWCqfQQ4Iyu8u01E@public.gmane.org>
2011-11-29 15:10 ` Peng Tao
2011-11-29 15:18 ` Trond Myklebust
2011-11-29 15:30 ` Peng Tao
2011-11-29 16:40 ` Trond Myklebust
[not found] ` <1322584830.4174.16.camel-SyLVLa/KEI9HwK5hSS5vWB2eb7JE58TQ@public.gmane.org>
2011-11-29 16:42 ` J. Bruce Fields
[not found] ` <20111129164252.GA19528-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2011-11-29 17:19 ` Trond Myklebust
[not found] ` <1322587165.4174.20.camel-SyLVLa/KEI9HwK5hSS5vWB2eb7JE58TQ@public.gmane.org>
2011-11-29 17:27 ` J. Bruce Fields
2011-11-29 17:30 ` Peng Tao
[not found] ` <CA+a=Yy4bEKaeUihjYLRzXVbjA3fc2EuZ3ToAkf0w-oL3PnZJKQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-05-28 11:43 ` Boaz Harrosh [this message]
2011-11-29 10:10 ` [PATCH 5/5] SUNRPC: kernel PipeFS mount point creation routines removed Stanislav Kinsbursky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC364F9.4090308@panasas.com \
--to=bharrosh-c4p08nqkorlbdgjk7y7tuq@public$(echo .)gmane.org \
--cc=Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=bergwolf-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=bfields-uC3wQj2KruNg9hUCZPvPmw@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=devel-GEFAQzZX7r8dnm+yROfE0A@public$(echo .)gmane.org \
--cc=jbottomley-bzQdu9zFT3WakBO8gow8eQ@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=neilb-l3A5Bk7waGM@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=skinsbursky-bzQdu9zFT3WakBO8gow8eQ@public$(echo .)gmane.org \
--cc=steved-H+wXaHxf7aLQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=tao.peng-mb1K0bWo544@public$(echo .)gmane.org \
--cc=xemul-bzQdu9zFT3WakBO8gow8eQ@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox