public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Gao feng <gaofeng@cn•fujitsu.com>
To: Steffen Klassert <steffen.klassert@secunet•com>
Cc: Eric Dumazet <eric.dumazet@gmail•com>,
	herbert@gondor•apana.org.au, davem@davemloft•net,
	netdev@vger•kernel.org, containers@lists•linux-foundation.org
Subject: Re: [PATCH net-next 1/2] inetpeer: add namespace support for inetpeer
Date: Tue, 05 Jun 2012 13:58:03 +0800	[thread overview]
Message-ID: <4FCD9FEB.9060208@cn.fujitsu.com> (raw)
In-Reply-To: <20120605055208.GA27795@secunet.com>

于 2012年06月05日 13:52, Steffen Klassert 写道:
> On Tue, Jun 05, 2012 at 05:40:19AM +0200, Eric Dumazet wrote:
>> On Tue, 2012-06-05 at 10:23 +0800, Gao feng wrote:
>>>  
>>> +static int __net_init inetpeer_net_init(struct net *net)
>>> +{
>>> +
>>> +	net->ipv4.peers = kmemdup(&v4_peers,
>>> +				  sizeof(v4_peers),
>>> +				  GFP_KERNEL);
>>
>> kzalloc(), and init ->root to peer_avl_empty_rcu
>>
>>> +	if (net->ipv4.peers == NULL)
>>> +		return -1;
> 
> ...and return -ENOMEM if memory allocation fails.

thanks Eric & Steffen
I miss it... I will fix it and send patch v2.

      reply	other threads:[~2012-06-05  5:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-05  2:23 [PATCH net-next 1/2] inetpeer: add namespace support for inetpeer Gao feng
     [not found] ` <1338863012-4902-1-git-send-email-gaofeng-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-06-05  2:23   ` [PATCH net-next 2/2] inetpeer: add parameter net for inet_getpeer_v4, v6 Gao feng
2012-06-05  3:40 ` [PATCH net-next 1/2] inetpeer: add namespace support for inetpeer Eric Dumazet
2012-06-05  5:52   ` Steffen Klassert
2012-06-05  5:58     ` Gao feng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FCD9FEB.9060208@cn.fujitsu.com \
    --to=gaofeng@cn$(echo .)fujitsu.com \
    --cc=containers@lists$(echo .)linux-foundation.org \
    --cc=davem@davemloft$(echo .)net \
    --cc=eric.dumazet@gmail$(echo .)com \
    --cc=herbert@gondor$(echo .)apana.org.au \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=steffen.klassert@secunet$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox