From: Michael Tokarev <mjt@tls•msk.ru>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: David Miller <davem@davemloft•net>,
netdev <netdev@vger•kernel.org>,
Steven Whitehouse <swhiteho@redhat•com>,
Pavel Emelyanov <xemul@parallels•com>
Subject: Re: [PATCH net-next] af_unix: speedup /proc/net/unix
Date: Sat, 09 Jun 2012 09:42:07 +0400 [thread overview]
Message-ID: <4FD2E22F.9090503@msgid.tls.msk.ru> (raw)
In-Reply-To: <1339167801.6001.111.camel@edumazet-glaptop>
On 08.06.2012 19:03, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google•com>
>
> /proc/net/unix has quadratic behavior, and can hold unix_table_lock for
> a while if high number of unix sockets are alive. (90 ms for 200k
> sockets...)
Two comments, nitpicking...
[]
> struct unix_iter_state {
> struct seq_net_private p;
> - int i;
> };
Can't seq_net_private be used directly?
> +static struct sock *unix_next_socket(struct seq_file *seq,
> + struct sock *sk,
> + loff_t *pos)
> +{
....
> }
>
> static void *unix_seq_next(struct seq_file *seq, void *v, loff_t *pos)
> {
> + return unix_next_socket(seq, v, pos);
> }
Why unix_seq_next() is needed? Can't unix_next_socket() be used directly instead?
Thanks,
/mjt
next prev parent reply other threads:[~2012-06-09 5:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 15:03 [PATCH net-next] af_unix: speedup /proc/net/unix Eric Dumazet
2012-06-08 21:28 ` David Miller
2012-06-09 5:42 ` Michael Tokarev [this message]
2012-06-09 8:10 ` Eric Dumazet
2012-06-10 2:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD2E22F.9090503@msgid.tls.msk.ru \
--to=mjt@tls$(echo .)msk.ru \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=swhiteho@redhat$(echo .)com \
--cc=xemul@parallels$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox