public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Weiping Pan <panweiping3@gmail•com>
To: Jay Vosburgh <fubar@us•ibm.com>
Cc: "Nicolas de Pesloüan" <nicolas.2p.debian@gmail•com>,
	"Weiping Pan" <wpan@redhat•com>,
	netdev@vger•kernel.org
Subject: Re: [PATCH net 1/3] bonding:record primary when modify it via sysfs
Date: Tue, 12 Jun 2012 11:38:04 +0800	[thread overview]
Message-ID: <4FD6B99C.7020305@gmail.com> (raw)
In-Reply-To: <31624.1339447734@death.nxdomain>

On 06/12/2012 04:48 AM, Jay Vosburgh wrote:
> Nicolas de Pesloüan 	<nicolas.2p.debian@gmail•com>  wrote:
>
>> Le 11/06/2012 11:00, Weiping Pan a écrit :
>>> If we modify primary via sysfs and it is not a valid slave,
>>> we should record it for future use, and this behavior is the same with
>>> bond_check_params().
>>>
>>> Signed-off-by: Weiping Pan<wpan@redhat•com>
>>> ---
>>>    drivers/net/bonding/bond_sysfs.c |    8 ++++++--
>>>    1 files changed, 6 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/bonding/bond_sysfs.c b/drivers/net/bonding/bond_sysfs.c
>>> index aef42f0..485bedb 100644
>>> --- a/drivers/net/bonding/bond_sysfs.c
>>> +++ b/drivers/net/bonding/bond_sysfs.c
>>> @@ -1082,8 +1082,12 @@ static ssize_t bonding_store_primary(struct device *d,
>>>    		}
>>>    	}
>>>
>>> -	pr_info("%s: Unable to set %.*s as primary slave.\n",
>>> -		bond->dev->name, (int)strlen(buf) - 1, buf);
>>> +	strncpy(bond->params.primary, ifname, IFNAMSIZ);
>>> +	bond->params.primary[IFNAMSIZ - 1] = 0;
>>> +
>>> +	pr_info("%s: Recording %s as primary, "
>>> +		"but it has not been enslaved to %s yet.\n",
>>> +		bond->dev->name, ifname, bond->dev->name);
>>>    out:
>>>    	write_unlock_bh(&bond->curr_slave_lock);
>>>    	read_unlock(&bond->lock);
>> I like this one, because it tend to relax the current constraints one
>> should respect on the order to write into sysfs to setup bonding.
>>
>> May I suggest we have a better info message, suggesting there might have a
>> typo on the name of the primary ?
>>
>>> +	pr_info("%s: Recording %s as primary, "
>>> +		"but it has not been enslaved to %s yet. Possible typo?\n",
>>> +		bond->dev->name, ifname, bond->dev->name);
>> Except from this cosmetic,
>>
>> Acked-by: Nicolas de Pesloüan<nicolas.2p.debian@free•fr>
> 	Agreed, except that I can go either way on the "typo" warning.

I prefer not to add 'typo' since I think the log is enough.

thanks
Weiping Pan
> Signed-off-by: Jay Vosburgh<fubar@us•ibm.com>
>
> 	-J
>
> ---
> 	-Jay Vosburgh, IBM Linux Technology Center, fubar@us•ibm.com
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

next prev parent reply	other threads:[~2012-06-12  3:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-11  9:00 [PATCH net 0/3] correct behavior when modify primary via sysfs Weiping Pan
2012-06-11  9:00 ` [PATCH net 1/3] bonding:record primary when modify it " Weiping Pan
2012-06-11 19:38   ` Nicolas de Pesloüan
2012-06-11 20:48     ` Jay Vosburgh
2012-06-12  3:38       ` Weiping Pan [this message]
2012-06-12 20:05       ` Nicolas de Pesloüan
2012-06-12 22:24         ` David Miller
2012-06-11  9:00 ` [PATCH net 2/3] bonding:check mode when modify primary_reselect Weiping Pan
2012-06-11 19:42   ` Nicolas de Pesloüan
2012-06-11 20:56     ` Jay Vosburgh
2012-06-11 21:13       ` Nicolas de Pesloüan
2012-06-11 21:28         ` Jay Vosburgh
2012-06-11  9:00 ` [PATCH net 3/3] bonding:force to use primary slave Weiping Pan
2012-06-11 19:49   ` Nicolas de Pesloüan
2012-06-11 21:17     ` Jay Vosburgh
2012-06-12  3:35       ` [PATCH net V2] " Weiping Pan
2012-06-12  5:00         ` Jay Vosburgh
2012-06-12  6:37           ` Weiping Pan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FD6B99C.7020305@gmail.com \
    --to=panweiping3@gmail$(echo .)com \
    --cc=fubar@us$(echo .)ibm.com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=nicolas.2p.debian@gmail$(echo .)com \
    --cc=wpan@redhat$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox