From: John Fastabend <john.r.fastabend@intel•com>
To: Thomas Graf <tgraf@redhat•com>
Cc: alexander.h.duyck@intel•com, David Miller <davem@davemloft•net>,
netdev@vger•kernel.org, lucy.liu@intel•com
Subject: Re: [PATCH 0/8] dcbnl: Major simplifications
Date: Fri, 15 Jun 2012 20:53:23 -0700 [thread overview]
Message-ID: <4FDC0333.5090806@intel.com> (raw)
In-Reply-To: <20120615072659.GD29738@canuck.infradead.org>
On 6/15/2012 12:26 AM, Thomas Graf wrote:
> On Thu, Jun 14, 2012 at 09:06:20AM -0700, John Fastabend wrote:
>> On 6/14/2012 12:54 AM, Thomas Graf wrote:
>>> On Wed, Jun 13, 2012 at 03:55:41PM -0700, David Miller wrote:
>>>> Lots of deleted code, I like it :-)
>>>>
>>>> Applied, but could you send a follow-on patch to use BUG_ON() instead
>>>> of that "if (!ptr) { /* ... */ BUG(); }" construct?
>>>
>>> Sure, I must have had a weak moment right there :)
>>>
>>
>> Nice! I'm a bit late but dumped this into my dcbnl netlink test kit
>> and everything looks good so...
>
> Thank you for testing John. Are you referring to lldp/test/nltest.c?
> I only discovered it after you mentioned a test kit. I've been feeding
> a list of commands through dcbtool for testing so far.
>
nltest works OK, I've got a variant here that I use to send/read
messages and also check the hardware registers on 82599. 'dcbtool'
works fine as well.
If I get some time I'll update nltest on open-lldp.
> BTW, I believe you mentioned at some point, that there is a patch
> available allowing non net_device based DCB users to use dcbnl.
> Otherwise I would start with the effort :)
>
Nope patch doesn't exist. I've been threatening to do it for awhile
now but haven't got to it. Yes please start it :)
I talked about it here once although it might be a bit out dated
now and I think if you have a lookup function then other things
besides scsci_hosts could be added easily,
http://www.linuxplumbersconf.org/2011/ocw/system/presentations/561/original/Plumbers2011.pdf
Thanks!
John
next prev parent reply other threads:[~2012-06-16 3:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 12:54 [PATCH 0/8] dcbnl: Major simplifications Thomas Graf
2012-06-13 12:54 ` [PATCH 1/8] dcbnl: Prepare framework to shorten handling functions Thomas Graf
2012-06-13 12:54 ` [PATCH 2/8] dcbnl: Shorten all command " Thomas Graf
2012-06-21 6:04 ` John Fastabend
2012-06-13 12:54 ` [PATCH 3/8] dcbnl: Remove now unused dcbnl_reply() Thomas Graf
2012-06-13 12:54 ` [PATCH 4/8] dcbnl: Use dcbnl_newmsg() where possible Thomas Graf
2012-06-13 12:54 ` [PATCH 5/8] dcbnl: Return consistent error codes Thomas Graf
2012-06-13 12:54 ` [PATCH 6/8] dcbnl: Move dcb app lookup code into dcb_app_lookup() Thomas Graf
2012-06-13 12:55 ` [PATCH 7/8] dcbnl: Move dcb app allocation into dcb_app_add() Thomas Graf
2012-06-13 12:55 ` [PATCH 8/8] dcbnl: Use type safe nlmsg_data() Thomas Graf
2012-06-13 22:55 ` [PATCH 0/8] dcbnl: Major simplifications David Miller
2012-06-14 7:54 ` Thomas Graf
2012-06-14 16:06 ` John Fastabend
2012-06-15 7:26 ` Thomas Graf
2012-06-16 3:53 ` John Fastabend [this message]
2012-06-14 8:40 ` [PATCH] dcbnl: Use BUG_ON() instead of BUG() Thomas Graf
2012-06-14 8:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDC0333.5090806@intel.com \
--to=john.r.fastabend@intel$(echo .)com \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=lucy.liu@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tgraf@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox