From: Vlad Yasevich <vyasevich@gmail•com>
To: Neil Horman <nhorman@tuxdriver•com>
Cc: David Miller <davem@davemloft•net>,
netdev@vger•kernel.org, linux-sctp@vger•kernel.org
Subject: Re: [PATCH] sctp: be mroe restrictive in transport selection on bundled sacks
Date: Wed, 27 Jun 2012 09:20:57 -0400 [thread overview]
Message-ID: <4FEB08B9.7030907@gmail.com> (raw)
In-Reply-To: <20120627102419.GA19313@hmsreliant.think-freely.org>
On 06/27/2012 06:24 AM, Neil Horman wrote:
> On Tue, Jun 26, 2012 at 09:05:04PM -0700, David Miller wrote:
>> From: Neil Horman<nhorman@tuxdriver•com>
>> Date: Tue, 26 Jun 2012 16:31:44 -0400
>>
>>> @@ -240,15 +240,20 @@ static sctp_xmit_t sctp_packet_bundle_sack(struct sctp_packet *pkt,
>>> */
>>> if (sctp_chunk_is_data(chunk)&& !pkt->has_sack&&
>>> !pkt->has_cookie_echo) {
>>> - struct sctp_association *asoc;
>>> struct timer_list *timer;
>>> - asoc = pkt->transport->asoc;
>>> + struct sctp_association *asoc = pkt->transport->asoc;
>>> + struct sctp_transport *trans;
>>> +
>>> timer =&asoc->timers[SCTP_EVENT_TIMEOUT_SACK];
>>>
>>> /* If the SACK timer is running, we have a pending SACK */
>>> if (timer_pending(timer)) {
>>> struct sctp_chunk *sack;
>>> asoc->a_rwnd = asoc->rwnd;
>>> +
>>> + if (chunk->transport&& !chunk->transport->moved_ctsn)
>>> + return retval;
>>> +
>>> sack = sctp_make_sack(asoc);
>>> if (sack) {
>>> retval = sctp_packet_append_chunk(pkt, sack);
>>
>> The new local variable 'trans' seems to be unused.
>>
> Crap, thank you Dave, that was a holdover from an initial pass I had made in
> writing this. I'll repost with that removed once Vald has a chance to look this
> over
> Neil
>
Also, may want to move a_rwnd adjustment to after the new if clause. No
sense adjusting it if we are just going to bail.
-vlad
next prev parent reply other threads:[~2012-06-27 13:21 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 20:31 [PATCH] sctp: be mroe restrictive in transport selection on bundled sacks Neil Horman
2012-06-27 4:05 ` David Miller
2012-06-27 10:24 ` Neil Horman
2012-06-27 13:20 ` Vlad Yasevich [this message]
2012-06-27 13:22 ` Neil Horman
2012-06-27 14:23 ` [PATCH v2] sctp: be more " Neil Horman
2012-06-27 15:10 ` Vlad Yasevich
2012-06-27 17:28 ` Neil Horman
2012-06-27 19:44 ` Vlad Yasevich
2012-06-28 15:33 ` Neil Horman
2012-06-28 15:58 ` Vlad Yasevich
2012-06-28 18:07 ` Neil Horman
2012-06-28 18:22 ` Vlad Yasevich
2012-06-28 18:36 ` Neil Horman
2012-06-28 20:14 ` Neil Horman
2012-06-29 16:34 ` [PATCH v3] " Neil Horman
2012-06-29 18:29 ` Vlad Yasevich
2012-06-29 18:43 ` Neil Horman
2012-06-29 19:15 ` Vlad Yasevich
2012-06-29 19:21 ` Neil Horman
2012-06-29 19:24 ` [PATCH v4] " Neil Horman
2012-06-29 20:15 ` [PATCH v5] " Neil Horman
2012-06-29 20:19 ` Vlad Yasevich
2012-06-29 23:34 ` David Miller
2012-06-30 12:26 ` Neil Horman
2012-07-01 0:38 ` David Miller
2012-06-30 13:04 ` [PATCH v6] " Neil Horman
2012-07-01 0:39 ` David Miller
2012-07-01 3:17 ` Vlad Yasevich
2012-07-01 5:44 ` David Miller
2012-07-01 12:47 ` Neil Horman
2012-07-01 21:43 ` David Miller
2012-07-01 23:44 ` Neil Horman
2012-07-02 12:25 ` Neil Horman
2012-07-03 0:10 ` David Miller
2012-07-03 18:45 ` Jan Ceuleers
2012-07-03 23:42 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEB08B9.7030907@gmail.com \
--to=vyasevich@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-sctp@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox