From: Gao feng <gaofeng@cn•fujitsu.com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: David Miller <davem@davemloft•net>,
nhorman@tuxdriver•com, linux-kernel@vger•kernel.org,
netdev@vger•kernel.org, lizefan@huawei•com, tj@kernel•org
Subject: Re: [PATCH] net: cgroup: fix out of bounds accesses
Date: Mon, 09 Jul 2012 16:15:29 +0800 [thread overview]
Message-ID: <4FFA9321.4030407@cn.fujitsu.com> (raw)
In-Reply-To: <1341819910.3265.2106.camel@edumazet-glaptop>
于 2012年07月09日 15:45, Eric Dumazet 写道:
> From: Eric Dumazet <edumazet@google•com>
>
> dev->priomap is allocated by extend_netdev_table() called from
> update_netdev_tables().
> And this is only called if write_priomap() is called.
>
> But if write_priomap() is not called, it seems we can have out of bounds
> accesses in cgrp_destroy(), read_priomap() & skb_update_prio()
>
> With help from Gao Feng
>
> Signed-off-by: Eric Dumazet <edumazet@google•com>
> Cc: Neil Horman <nhorman@tuxdriver•com>
> Cc: Gao feng <gaofeng@cn•fujitsu.com>
> ---
> net/core/dev.c | 8 ++++++--
> net/core/netprio_cgroup.c | 4 ++--
> 2 files changed, 8 insertions(+), 4 deletions(-)
Acked-by: Gao feng <gaofeng@cn•fujitsu.com>
next prev parent reply other threads:[~2012-07-09 8:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 7:45 [PATCH] net: cgroup: fix out of bounds accesses Eric Dumazet
2012-07-09 8:15 ` Gao feng [this message]
2012-07-09 21:51 ` David Miller
2012-07-10 2:33 ` Gao feng
2012-07-10 2:37 ` David Miller
2012-07-09 11:01 ` Neil Horman
2012-07-09 11:50 ` Eric Dumazet
2012-07-09 12:13 ` Neil Horman
2012-07-09 12:40 ` Eric Dumazet
2012-07-09 12:56 ` Neil Horman
2012-07-10 2:31 ` [PATCH] net: cgroup: fix access the unallocated memory in netprio cgroup Gao feng
2012-07-10 4:14 ` Eric Dumazet
2012-07-10 8:53 ` Gao feng
2012-07-10 9:15 ` Eric Dumazet
2012-07-10 9:36 ` Gao feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFA9321.4030407@cn.fujitsu.com \
--to=gaofeng@cn$(echo .)fujitsu.com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=lizefan@huawei$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
--cc=tj@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox