Subject: Re: [PATCH] net/fsl_pq_mdio: use spin_event_timeout() to poll the indicator register

From: Tabi Timur-B04825 <[email-masked]>
Date: Mon, 9 Jul 2012 14:31:33 +0000

David Miller wrote:

> Define a macro for the timeout value rather than use an arbitrary
> constant.

Ok.

>> +	status = spin_event_timeout(!(in_be32(&regs->miimind) &	MIIMIND_BUSY),
>> +		1000, 0);
>
> This indentation is absolutely terrible.

Can you give me a clue as to how you think it should look?  I could not 
come up with a good way to break up these lines and keep them under 80 
characters.

-- 
Timur Tabi
Linux kernel developer at Freescale