Subject: Re: [PATCH] net/fsl_pq_mdio: use spin_event_timeout() to poll the indicator register

From: Jan Ceuleers <[email-masked]>
Date: Mon, 09 Jul 2012 21:50:46 +0200

On 07/09/2012 04:31 PM, Tabi Timur-B04825 wrote:
>> This indentation is absolutely terrible.
> 
> Can you give me a clue as to how you think it should look?  I could not 
> come up with a good way to break up these lines and keep them under 80 
> characters.
> 

How about this:

+	status = spin_event_timeout(!(in_be32(&regs->miimind) &	MIIMIND_BUSY),
+				    1000, 0);

On the second line use as many tabs as possible, then continue with spaces until the '1' in 1000 lines up with the '!'.

HTH, Jan