public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Li Wei <lw@cn•fujitsu.com>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, shemminger@vyatta•com
Subject: Re: [PATCH V2] ipv6: fix incorrect route 'expires' value passed to userspace
Date: Fri, 20 Jul 2012 09:32:18 +0800	[thread overview]
Message-ID: <5008B522.4030005@cn.fujitsu.com> (raw)
In-Reply-To: <20120719.104906.38765587582698093.davem@davemloft.net>

于 2012-7-20 1:49, David Miller 写道:
> From: Li Wei <lw@cn•fujitsu.com>
> Date: Thu, 19 Jul 2012 10:02:59 +0800
> 
>>
>> When userspace use RTM_GETROUTE to dump route table, with an already
>> expired route entry, we always got an 'expires' value(2147157)
>> calculated base on INT_MAX.
>>
>> The reason of this problem is in the following satement:
>> 	rt->dst.expires - jiffies < INT_MAX
>> gcc promoted the type of both sides of '<' to unsigned long, thus
>> a small negative value would be considered greater than INT_MAX.
>>
>> This patch fix this by use the same trick as time_after macro to
>> avoid the 'unsigned long' type promotion and deal with jiffies
>> wrapping.
>>
>> Also we should do some fix in rtnl_put_cacheinfo() which use
>> jiffies_to_clock_t(which take an unsigned long as parameter) to
>> convert jiffies to clock_t to handle the negative expires.
>>
>> Signed-off-by: Li Wei <lw@cn•fujitsu.com>
> 
> Your patch is corrupted by your email client and therefore will
> not apply cleanly.
> 
> I think this isn't the first time your patch submissions have
> had this problem, and if so then you should do the necessary
> work to prevent problem with more certainty in the future as
> such this makes a lot of extra work for other people.
> 

Really sorry for that, I'll resend this patch and before that sending
myself a copy to confirm the mail client works properly.

Thanks

next prev parent reply	other threads:[~2012-07-20  1:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-16  8:09 [PATCH] ipv6: fix incorrect route 'expires' value passed to userspace Li Wei
2012-07-16  9:56 ` David Miller
2012-07-17  1:55   ` Li Wei
2012-07-19  2:02   ` [PATCH V2] " Li Wei
2012-07-19 17:49     ` David Miller
2012-07-20  1:32       ` Li Wei [this message]
2012-07-20  1:42       ` [PATCH V2 resend] " Li Wei
2012-07-20 10:32         ` David Laight
2012-07-20 18:22           ` David Miller
2012-07-23  1:05             ` Li Wei
2012-07-25  5:25             ` [PATCH V3] " Li Wei
2012-07-25  6:51               ` Eric Dumazet
2012-07-25  7:33                 ` Li Wei
2012-07-30  2:01                 ` [PATCH v4] " Li Wei
2012-07-30  6:20                   ` David Miller
2012-07-23  1:02           ` [PATCH V2 resend] " Li Wei
2012-07-16 16:41 ` [PATCH] " Stephen Hemminger
2012-07-17  1:53   ` Li Wei
2012-07-17  5:26   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5008B522.4030005@cn.fujitsu.com \
    --to=lw@cn$(echo .)fujitsu.com \
    --cc=davem@davemloft$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=shemminger@vyatta$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox