From: "Nicolas de Pesloüan" <nicolas.2p.debian@gmail•com>
To: David Miller <davem@davemloft•net>
Cc: ja@ssi•bg, netdev@vger•kernel.org
Subject: Re: [PATCH 2/2] ipv4: Change rt->rt_iif encoding.
Date: Wed, 25 Jul 2012 00:13:55 +0200 [thread overview]
Message-ID: <500F1E23.7090803@gmail.com> (raw)
In-Reply-To: <20120723.161446.36265037346365173.davem@davemloft.net>
Le 24/07/2012 01:14, David Miller a écrit :
[...]
> I wonder if we should just get rid of all of that orig_dev logic and
> simply update skb->skb_iif every time we hit the code starting at
> label "another_round"
It clearly depends on the exact meaning of orig_dev.
When we studied the usage of orig_dev before removing it from bonding, it was clear that two
different meanings existed:
- From the bonding point of view, is was "the device one level below current device" (the slave,
from the master's point of view).
- From the af_packet point of view, is was "the real original device that received the packet".
As bonding don't use orig_dev anymore, the remaining meaning should logically be "the real original
device that received the packet". But as __netif_receive_skb() is recursively called in many cases,
setting orig_dev to something new every time, this meaning is probably mostly inconsistent. As such,
it sounds appropriate to remove orig_dev and use skb_iif instead.
Nicolas.
next prev parent reply other threads:[~2012-07-24 22:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 21:07 [PATCH 2/2] ipv4: Change rt->rt_iif encoding David Miller
2012-07-23 22:22 ` David Miller
2012-07-23 23:04 ` David Miller
2012-07-23 23:11 ` Julian Anastasov
2012-07-23 23:05 ` David Miller
2012-07-23 23:14 ` David Miller
2012-07-24 0:24 ` Julian Anastasov
2012-07-24 0:43 ` David Miller
2012-07-24 7:41 ` Julian Anastasov
2012-07-24 22:13 ` Nicolas de Pesloüan [this message]
2012-07-24 22:18 ` David Miller
2012-07-24 22:25 ` Nicolas de Pesloüan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500F1E23.7090803@gmail.com \
--to=nicolas.2p.debian@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ja@ssi$(echo .)bg \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox