public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Pavel Emelyanov <xemul@parallels•com>
To: David Laight <David.Laight@ACULAB•COM>
Cc: Stephen Hemminger <shemminger@linux-foundation•org>,
	Linux Netdev List <netdev@vger•kernel.org>
Subject: Re: [PATCH 1/2] iproute: Add magic cookie to route dump file
Date: Fri, 27 Jul 2012 17:35:27 +0400	[thread overview]
Message-ID: <5012991F.9030806@parallels.com> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B6FB1@saturn3.aculab.com>

On 07/27/2012 02:46 PM, David Laight wrote:
>> In order to somehow verify that a blob contains route dump a
>> 4-bytes magic is put at the head of the data and is checked
>> on restore.
> 
> Wouldn't a hash/checksum be useful as well?

I doubt it. This magic is not for data integrity check, but is
rather for identification of it. Is someone really needs a cheksum
of a dump, it can be added after file generation (and by the
preferred tool, not limited with the iproute implementation).

> Especially if it uneditable data.
> 
> 	David
> 
> 
> 

  reply	other threads:[~2012-07-27 13:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-27  4:55 [PATCH 1/2] iproute: Add magic cookie to route dump file Pavel Emelyanov
2012-07-27  4:57 ` [PATCH 2/2] iproute: Add route showdump command (v2) Pavel Emelyanov
2012-07-27  5:03   ` Pavel Emelyanov
2012-07-27  6:06     ` Pavel Emelyanov
2012-07-27 17:05       ` Stephen Hemminger
2012-09-11 15:47     ` [PATCH] iproute: Add ability to save, restore and show the interfaces' addresses (resend) Pavel Emelyanov
2012-09-11 16:18       ` Stephen Hemminger
2012-09-07 16:14   ` [PATCH 2/2] iproute: Add route showdump command (v2) Stephen Hemminger
2012-07-27 10:46 ` [PATCH 1/2] iproute: Add magic cookie to route dump file David Laight
2012-07-27 13:35   ` Pavel Emelyanov [this message]
2012-07-27 16:59 ` Stephen Hemminger
2012-08-17 20:49 ` Stephen Hemminger
2012-08-20  8:05   ` Pavel Emelyanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5012991F.9030806@parallels.com \
    --to=xemul@parallels$(echo .)com \
    --cc=David.Laight@ACULAB$(echo .)COM \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=shemminger@linux-foundation$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox