From: Wolfgang Grandegger <wg@grandegger•com>
To: Marc Kleine-Budde <mkl@pengutronix•de>
Cc: Olivier Sobrie <olivier@sobrie•be>,
linux-can@vger•kernel.org, netdev@vger•kernel.org
Subject: Re: [PATCH] can: kvaser_usb: Add support for Kvaser CAN/USB devices
Date: Sun, 05 Aug 2012 22:41:10 +0200 [thread overview]
Message-ID: <501EDA66.4090708@grandegger.com> (raw)
In-Reply-To: <5017ABC6.7030307@pengutronix.de>
On 07/31/2012 11:56 AM, Marc Kleine-Budde wrote:
> On 07/30/2012 03:33 PM, Olivier Sobrie wrote:
...
>>>> +static void kvaser_usb_rx_error(const struct kvaser_usb *dev,
>>>> + const struct kvaser_msg *msg)
>>>> +{
>>>> + struct can_frame *cf;
>>>> + struct sk_buff *skb;
>>>> + struct net_device_stats *stats;
>>>> + struct kvaser_usb_net_priv *priv;
>>>> + u8 channel, status, txerr, rxerr;
>>>> +
>>>> + if (msg->id == CMD_CAN_ERROR_EVENT) {
>>>> + channel = msg->u.error_event.channel;
>>>> + status = msg->u.error_event.status;
>>>> + txerr = msg->u.error_event.tx_errors_count;
>>>> + rxerr = msg->u.error_event.rx_errors_count;
>>>> + } else {
>>>> + channel = msg->u.chip_state_event.channel;
>>>> + status = msg->u.chip_state_event.status;
>>>> + txerr = msg->u.chip_state_event.tx_errors_count;
>>>> + rxerr = msg->u.chip_state_event.rx_errors_count;
>>>> + }
>>>> +
>>>> + if (channel >= dev->nchannels) {
>>>> + dev_err(dev->udev->dev.parent,
>>>> + "Invalid channel number (%d)\n", channel);
>>>> + return;
>>>> + }
>>>> +
>>>> + priv = dev->nets[channel];
>>>> + stats = &priv->netdev->stats;
>>>> +
>>>> + skb = alloc_can_err_skb(priv->netdev, &cf);
>>>> + if (!skb) {
>>>> + stats->rx_dropped++;
>>>> + return;
>>>> + }
>>>> +
>>>> + if ((status & M16C_STATE_BUS_OFF) ||
>>>> + (status & M16C_STATE_BUS_RESET)) {
>>>> + priv->can.state = CAN_STATE_BUS_OFF;
>>>> + cf->can_id |= CAN_ERR_BUSOFF;
>>>> + can_bus_off(priv->netdev);
>
> you should increment priv->can.can_stats.bus_off
No, already done in can_bus_off():
http://lxr.free-electrons.com/source/drivers/net/can/dev.c#L439
Wolfgang.
next prev parent reply other threads:[~2012-08-05 20:41 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 5:32 [PATCH] can: kvaser_usb: Add support for Kvaser CAN/USB devices Olivier Sobrie
2012-07-30 11:11 ` Marc Kleine-Budde
2012-07-30 13:33 ` Olivier Sobrie
2012-07-31 9:56 ` Marc Kleine-Budde
2012-07-31 13:06 ` Olivier Sobrie
2012-07-31 13:27 ` Marc Kleine-Budde
2012-08-02 10:53 ` Olivier Sobrie
2012-08-02 11:56 ` Marc Kleine-Budde
2012-08-02 12:16 ` Olivier Sobrie
2012-08-02 12:33 ` Marc Kleine-Budde
2012-08-02 13:20 ` Olivier Sobrie
2012-08-05 20:43 ` Wolfgang Grandegger
2012-08-06 5:27 ` Olivier Sobrie
2012-07-31 13:43 ` Wolfgang Grandegger
2012-08-05 20:41 ` Wolfgang Grandegger [this message]
2012-08-06 5:21 ` [PATCH v2] " Olivier Sobrie
2012-08-06 8:10 ` Oliver Neukum
2012-08-08 5:28 ` Olivier Sobrie
2012-08-07 6:26 ` Wolfgang Grandegger
2012-08-08 6:14 ` Olivier Sobrie
2012-08-08 8:25 ` Wolfgang Grandegger
[not found] ` <5022227F.60800-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2012-08-08 13:30 ` Olivier Sobrie
2012-08-08 15:02 ` Wolfgang Grandegger
2012-08-13 13:51 ` [PATCH v3] " Olivier Sobrie
2012-09-20 5:06 ` [PATCH v4] " Olivier Sobrie
[not found] ` <1348117587-2905-1-git-send-email-olivier-Ui3EtX6WB9GzQB+pC5nmwQ@public.gmane.org>
2012-09-21 9:54 ` Marc Kleine-Budde
2012-09-22 16:02 ` Wolfgang Grandegger
[not found] ` <505DE106.6060405-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2012-10-02 7:14 ` Olivier Sobrie
2012-10-02 7:16 ` [PATCH v5] " Olivier Sobrie
2012-11-07 20:29 ` Marc Kleine-Budde
2012-11-20 8:46 ` Olivier Sobrie
2012-11-20 10:59 ` Marc Kleine-Budde
[not found] ` <1343626352-24760-1-git-send-email-olivier-Ui3EtX6WB9GzQB+pC5nmwQ@public.gmane.org>
2012-11-21 7:11 ` [PATCH v6] " Olivier Sobrie
2012-11-22 11:01 ` Marc Kleine-Budde
2012-11-22 15:01 ` Olivier Sobrie
2012-11-22 21:30 ` Greg KH
2012-11-23 8:48 ` Marc Kleine-Budde
2012-11-23 13:30 ` [PATCH] kvaser_usb: fix "dma on the stack" errors Olivier Sobrie
2012-11-23 13:40 ` Olivier Sobrie
2012-11-23 13:48 ` Marc Kleine-Budde
2012-11-23 13:54 ` [PATCH v2] " Olivier Sobrie
2012-11-23 14:08 ` Marc Kleine-Budde
2012-11-23 14:16 ` Olivier Sobrie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501EDA66.4090708@grandegger.com \
--to=wg@grandegger$(echo .)com \
--cc=linux-can@vger$(echo .)kernel.org \
--cc=mkl@pengutronix$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olivier@sobrie$(echo .)be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox