Subject: Re: [PATCH 3/5 (resend)] veth: Allow to create peer link with given ifindex

From: Pavel Emelyanov <[email-masked]>
Date: Wed, 08 Aug 2012 17:38:49 +0400

>> You're right, I've missed that fact :( The good news is that we still can
>> use the ifmp->ifi_index for the peer index configuration. We just need to
>> assume that if the caller specified the ifindex for the veth master device,
>> then it's aware of this possibility and should explicitly configure (or set
>> to 0) the peer's ifindex as well. Like this:
>>
>> 	if (ifmp && (dev->ifindex != 0))
>> 		peer->ifindex = ifmp->ifi_index;
>>
>> Does this assumption work from you POV?
> 
> Yes, that looks like a neat way to do it.  Maybe with an explanatory
> comment?

Yes, sure. I will resend the set shortly.
Thanks for the feedback!

> Ben.

Thanks,
Pavel