public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Pavel Emelyanov <xemul-bzQdu9zFT3WakBO8gow8eQ@public•gmane.org>
To: "H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public•gmane.org>,
	Alan Cox <alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public•gmane.org>,
	Stanislav Kinsbursky
	<skinsbursky-bzQdu9zFT3WakBO8gow8eQ@public•gmane.org>
Cc: "J. Bruce Fields"
	<bfields-uC3wQj2KruNg9hUCZPvPmw@public•gmane.org>,
	"Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public•gmane.org"
	<Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public•gmane.org>,
	"davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org"
	<davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org>,
	"linux-nfs-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
	<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
	"eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org"
	<eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>,
	"netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
	<netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
	"viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public•gmane.org"
	<viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public•gmane.org>,
	"tim.c.chen-VuQAYsv1563Yd54FQh9/CA@public•gmane.org"
	<tim.c.chen-VuQAYsv1563Yd54FQh9/CA@public•gmane.org>,
	"devel-GEFAQzZX7r8dnm+yROfE0A@public•gmane.org"
	<devel-GEFAQzZX7r8dnm+yROfE0A@public•gmane.org>
Subject: Re: [RFC PATCH 0/2] net: connect to UNIX sockets from specified root
Date: Sat, 11 Aug 2012 10:23:22 +0400	[thread overview]
Message-ID: <5025FA5A.4090403@parallels.com> (raw)
In-Reply-To: <50259494.8060304-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>

On 08/11/2012 03:09 AM, H. Peter Anvin wrote:
> On 08/10/2012 12:28 PM, Alan Cox wrote:
>> Explicitly for Linux yes - this is not generally true of the AF_UNIX
>> socket domain and even the permissions aspect isn't guaranteed to be
>> supported on some BSD environments !
> 
> Yes, but let's worry about what the Linux behavior should be.
> 
>> The name is however just a proxy for the socket itself. You don't even
>> get a device node in the usual sense or the same inode in the file system
>> space.
> 
> 
> No, but it is looked up the same way any other inode is (the difference
> between FIFOs and sockets is that sockets have separate connections,
> which is also why open() on sockets would be nice.)
> 
> However, there is a fundamental difference between AF_UNIX sockets and
> open(), and that is how the pathname is delivered.  It thus would make
> more sense to provide the openat()-like information in struct
> sockaddr_un, but that may be very hard to do in a sensible way.  In that
> sense it perhaps would be cleaner to be able to do an open[at]() on the
> socket node with O_PATH (perhaps there should be an O_SOCKET option,
> even?) and pass the resulting file descriptor to bind() or connect().

I vote for this (openat + O_WHATEVER on a unix socket) as well. It will 
help us in checkpoint-restore, making handling of overmounted/unlinked
sockets much cleaner.

> 	-hpa

Thanks,
Pavel

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2012-08-11  6:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-10 12:57 [RFC PATCH 0/2] net: connect to UNIX sockets from specified root Stanislav Kinsbursky
     [not found] ` <20120810125701.7115.71612.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2012-08-10 12:57   ` [RFC PATCH 1/2] unix sockets: add ability for search for peer from passed root Stanislav Kinsbursky
2012-08-10 18:10     ` J. Bruce Fields
     [not found]       ` <20120810181002.GB17404-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2012-08-10 18:43         ` Stanislav Kinsbursky
2012-08-10 18:15   ` [RFC PATCH 0/2] net: connect to UNIX sockets from specified root H. Peter Anvin
2012-08-10 18:26     ` Alan Cox
     [not found]       ` <20120810192628.79a34d28-38n7/U1jhRXW96NNrWNlrekiAK3p4hvP@public.gmane.org>
2012-08-10 18:31         ` H. Peter Anvin
     [not found]           ` <5025537D.9060300-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2012-08-10 18:40             ` Alan Cox
2012-08-10 18:42               ` H. Peter Anvin
2012-08-10 19:11       ` J. Bruce Fields
     [not found]         ` <20120810191149.GA17985-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2012-08-10 19:28           ` Alan Cox
2012-08-10 23:09             ` H. Peter Anvin
     [not found]               ` <50259494.8060304-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2012-08-11  6:23                 ` Pavel Emelyanov [this message]
2012-08-11 11:15                   ` Stanislav Kinsbursky
2012-08-13 16:47                     ` J. Bruce Fields
2012-08-13 17:39                       ` Stanislav Kinsbursky
2012-08-13 18:24                         ` J. Bruce Fields
     [not found]                           ` <20120813182431.GA4234-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2012-08-14  8:46                             ` Stanislav Kinsbursky
2012-08-10 18:50     ` Stanislav Kinsbursky
2012-08-10 12:57 ` [RFC PATCH 2/2] SUNRPC: connect local transports with unix_stream_connect_root() helper Stanislav Kinsbursky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5025FA5A.4090403@parallels.com \
    --to=xemul-bzqdu9zft3wakbo8gow8eq@public$(echo .)gmane.org \
    --cc=Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public$(echo .)gmane.org \
    --cc=alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public$(echo .)gmane.org \
    --cc=bfields-uC3wQj2KruNg9hUCZPvPmw@public$(echo .)gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
    --cc=devel-GEFAQzZX7r8dnm+yROfE0A@public$(echo .)gmane.org \
    --cc=eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
    --cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public$(echo .)gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
    --cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
    --cc=skinsbursky-bzQdu9zFT3WakBO8gow8eQ@public$(echo .)gmane.org \
    --cc=tim.c.chen-VuQAYsv1563Yd54FQh9/CA@public$(echo .)gmane.org \
    --cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public$(echo .)gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox