From: Daniel Wagner <wagi-kQCPcA+X3s7YtjvyW6yDsg@public•gmane.org>
To: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public•gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
Daniel Wagner
<daniel.wagner-98C5kh4wR6ohFhg+JK9F0w@public•gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org>,
Al Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public•gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public•gmane.org>,
Eric Dumazet <edumazet-hpIqsD4AKlfQT0dZR+AlfA@public•gmane.org>,
Gao feng <gaofeng-BthXqXjhjHXQFUHtdCDX3A@public•gmane.org>,
Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public•gmane.org>,
Jamal Hadi Salim <jhs-jkUAjuhPggJWk0Htik3J/w@public•gmane.org>,
John Fastabend
<john.r.fastabend-ral2JQCrhuEAvxtiuMwx3w@public•gmane.org>,
Kamezawa Hiroyuki
<kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public•gmane.org>,
Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public•gmane.org>,
Tim Chen <tim.c.chen-VuQAYsv1563Yd54FQh9/CA@public•gmane.org>
Subject: Re: [PATCH v3 0/6] cgroup cls & netprio 'cleanups'
Date: Tue, 14 Aug 2012 15:25:50 +0200 [thread overview]
Message-ID: <502A51DE.7040809@monom.org> (raw)
In-Reply-To: <20120814131035.GC18731-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
Hi Neil,
On 14.08.2012 15:10, Neil Horman wrote:
> On Tue, Aug 14, 2012 at 03:02:16PM +0200, Daniel Wagner wrote:
>> From: Daniel Wagner <daniel.wagner-98C5kh4wR6ohFhg+JK9F0w@public•gmane.org>
>>
>> Hi,
>>
>> Sorry for the delay on updating this series. The usual
>> excuse apply here.
>>
>> I saw that John is busy improving net_prio so I took the
>> liberty to port his changes to net_cls (#1-3). Patch #3 will
>> collide with John's unapplied patches. I am happy
>> to rebase this series if needed.
>>
>> Patch #4 and #5 improve the readability with using
>> IS_MODULE/BUILTIN macros. This patches prepare the last
>> patch.
>>
>> Patch #6 removes support for assigning subsystem IDs during
>> runtime. As it turns out this is not really needed. By doing
>> so we are able to free some unused memory.
>>
>> The patches are against net-next.
>>
>> cheers,
>> daniel
>>
> These aren't so much 'cleanups' as feature enhancements and fixes for the first
> pass of those enhancements (at least in the case of the net_prio cgroup).
Sorry about that. I wanted to keep the series title, so that someone
looking up older versions find it.
> I've nothing against them, but since we're still going through some churn on the
> net_prio variant, it may be best to wait until thats settled before moving them
> over to net_cls.
Sure, I can update this series when the net_prio controller changes have
settled down.
I just wonder if it wouldn't make sense to merge them together.
Obviously, that will break the user space which is not a good thing but
having a controller per socket option is not good either.
cheers,
daniel
next prev parent reply other threads:[~2012-08-14 13:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 13:02 [PATCH v3 0/6] cgroup cls & netprio 'cleanups' Daniel Wagner
2012-08-14 13:02 ` [PATCH v3 1/6] cgroup: Move cls function definition to cls_cgroup.h Daniel Wagner
2012-08-14 13:02 ` [PATCH v3 4/6] cgroup: Use IS_MODULE/BUITLIN for net_cls Daniel Wagner
2012-08-14 13:02 ` [PATCH v3 5/6] cgroup: Use IS_MODULE/BUITLIN for net_prio Daniel Wagner
2012-08-14 13:02 ` [PATCH v3 6/6] cgroup: Assign subsystem IDs during compile time Daniel Wagner
[not found] ` <1344949343-26090-8-git-send-email-wagi-kQCPcA+X3s7YtjvyW6yDsg@public.gmane.org>
2012-08-14 17:27 ` Tejun Heo
[not found] ` <20120814172749.GL25632-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-08-14 21:01 ` Daniel Wagner
[not found] ` <1344949343-26090-1-git-send-email-wagi-kQCPcA+X3s7YtjvyW6yDsg@public.gmane.org>
2012-08-14 13:02 ` [PATCH v3 2/6] cgroup: net_cls rework update socket logic Daniel Wagner
2012-08-14 13:02 ` [PATCH v3 2/5] cgroup: " Daniel Wagner
2012-08-14 13:02 ` [PATCH v3 3/6] cgroup: Update classid for fd pass in SCM_RIGHTS datagramm Daniel Wagner
2012-08-14 13:10 ` [PATCH v3 0/6] cgroup cls & netprio 'cleanups' Neil Horman
[not found] ` <20120814131035.GC18731-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2012-08-14 13:25 ` Daniel Wagner [this message]
[not found] ` <502A51DE.7040809-kQCPcA+X3s7YtjvyW6yDsg@public.gmane.org>
2012-08-14 13:30 ` Neil Horman
[not found] ` <20120814133053.GD18731-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2012-08-14 13:46 ` Daniel Wagner
[not found] ` <502A56C9.8070701-kQCPcA+X3s7YtjvyW6yDsg@public.gmane.org>
2012-08-14 15:37 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502A51DE.7040809@monom.org \
--to=wagi-kqcpca+x3s7ytjvyw6ydsg@public$(echo .)gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public$(echo .)gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=daniel.wagner-98C5kh4wR6ohFhg+JK9F0w@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=edumazet-hpIqsD4AKlfQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=gaofeng-BthXqXjhjHXQFUHtdCDX3A@public$(echo .)gmane.org \
--cc=glommer-bzQdu9zFT3WakBO8gow8eQ@public$(echo .)gmane.org \
--cc=jhs-jkUAjuhPggJWk0Htik3J/w@public$(echo .)gmane.org \
--cc=john.r.fastabend-ral2JQCrhuEAvxtiuMwx3w@public$(echo .)gmane.org \
--cc=kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public$(echo .)gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=nhorman-2XuSBdqkA4R54TAoqtyWWQ@public$(echo .)gmane.org \
--cc=tim.c.chen-VuQAYsv1563Yd54FQh9/CA@public$(echo .)gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public$(echo .)gmane.org \
--cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox