public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale•com>
To: Kumar Gala <galak@kernel•crashing.org>
Cc: Andy Fleming <afleming@freescale•com>,
	Scott Wood <scottwood@freescale•com>, <ddaney.cavm@gmail•com>,
	<linuxppc-dev@ozlabs•org>, <netdev@vger•kernel.org>
Subject: Re: [PATCH 2/2] powerpc/85xx: add Fman MDIO muxing support to the P4080DS
Date: Tue, 14 Aug 2012 16:48:51 -0500	[thread overview]
Message-ID: <502AC7C3.9030902@freescale.com> (raw)
In-Reply-To: <5F0028FE-C555-47DE-B69A-888E7322A6E1@kernel.crashing.org>

Kumar Gala wrote:
>> > +	{
>> > +		/*
>> > +		 * Warning: this entry might need to be located before those
>> > +		 * for the Fman Ethernet nodes.
>> > +		 */
>> > +		.compatible	= "mdio-mux",
>> > +	},
>> > 	{}
>> > };
> Under what condition would that be the case?

We had this discussion already.  In my tests, I had to locate this entry
before these entries:

	{
		.compatible	= "fsl,dpaa"
	},
	{
		.compatible	= "fsl,srio",
	},

otherwise, the mdio-mux code would not prepare the mdio mus in time, and
there would be initialization failures.  Now maybe this goes away with
-EPROBE_DEFER, or maybe it doesn't.  But until we push the DPAA drivers
upstream, we won't know.

-- 
Timur Tabi
Linux kernel developer at Freescale

  reply	other threads:[~2012-08-14 21:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-10 22:31 [PATCH 1/2] powerpc/85xx: add the Fman device tree template include files Timur Tabi
2012-08-10 22:31 ` [PATCH 2/2] powerpc/85xx: add Fman MDIO muxing support to the P4080DS Timur Tabi
2012-08-14 21:45   ` Kumar Gala
2012-08-14 21:48     ` Timur Tabi [this message]
2012-08-14 21:53       ` Scott Wood
2012-08-14 21:58         ` Timur Tabi
2012-08-14 23:06           ` Scott Wood
2012-08-14 23:08             ` Timur Tabi
2012-08-14 23:12               ` Scott Wood
2012-08-10 22:34 ` [PATCH 1/2] powerpc/85xx: add the Fman device tree template include files Scott Wood
2012-08-10 22:37   ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502AC7C3.9030902@freescale.com \
    --to=timur@freescale$(echo .)com \
    --cc=afleming@freescale$(echo .)com \
    --cc=ddaney.cavm@gmail$(echo .)com \
    --cc=galak@kernel$(echo .)crashing.org \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=scottwood@freescale$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox