From: Daniel Wagner <wagi@monom•org>
To: Li Zefan <lizefan@huawei•com>
Cc: Tejun Heo <tj@kernel•org>,
netdev@vger•kernel.org, cgroups@vger•kernel.org,
Daniel Wagner <daniel.wagner@bmw-carit•de>,
"David S. Miller" <davem@davemloft•net>,
Andrew Morton <akpm@linux-foundation•org>,
Eric Dumazet <edumazet@google•com>,
Gao feng <gaofeng@cn•fujitsu.com>,
Glauber Costa <glommer@parallels•com>,
Jamal Hadi Salim <jhs@mojatatu•com>,
John Fastabend <john.r.fastabend@intel•com>,
Kamezawa Hiroyuki <kamezawa.hiroyu@jp•fujitsu.com>,
Neil Horman <nhorman@tuxdriver•com>
Subject: Re: [PATCH v0 5/5] cgroup: Assign subsystem IDs during compile time
Date: Fri, 17 Aug 2012 10:48:18 +0200 [thread overview]
Message-ID: <502E0552.3080602@monom.org> (raw)
In-Reply-To: <502DF1DF.8040109@huawei.com>
On 17.08.2012 09:25, Li Zefan wrote:
> On 2012/8/17 7:20, Tejun Heo wrote:
>> On Thu, Aug 16, 2012 at 04:12:16PM +0200, Daniel Wagner wrote:
>>> From: Daniel Wagner <daniel.wagner@bmw-carit•de>
>>>
>>> We are able to safe some space when we assign the subsystem
>>> IDs at compile time. Instead of allocating per cgroup
>>> cgroup->subsys[CGROUP_SUBSYS_COUNT] where CGROUP_SUBSYS_COUNT is
>>> always 64, we allocate 12 + 1 at max (at this point there are 12
>>> subsystem).
>>
>> So, IIUC, this is effectively removing the capability to implement
>> modularized controller which isn't known at kernel compile time. Am I
>> right?
>>
>
> I think so.
I am preparing an updated version which does not need the extra 1
pointer. Some more preprocessor magic involved :)
>> I don't think that's a bad idea but if we're doing that, can't we make
>> things even simpler? Do we need to distinguish in-kernel and module
>> at all?
>>
>> Li, what do you think about this?
>>
>
> I'm definitely all for simplicity, but I'm not sure if we can do better in
> simplifying the code for modularized cgroup subsystem. (I guess you didn't
> mean to remove this feature?)
The new version should also be simpler to review because I don't have to
touch the loops everywhere.
daniel
next prev parent reply other threads:[~2012-08-17 8:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 14:12 [PATCH v0 0/5] cgroup: Assign subsystem IDs during compile time Daniel Wagner
2012-08-16 14:12 ` [PATCH v0 2/5] cgroup: Move sock_update_classid() decleration to cls_cgroup.h Daniel Wagner
2012-08-16 14:12 ` [PATCH v0 3/5] cgroup: Protect access to task_cls_classid() when built as module Daniel Wagner
[not found] ` <1345126336-20755-4-git-send-email-wagi-kQCPcA+X3s7YtjvyW6yDsg@public.gmane.org>
2012-08-17 7:35 ` Li Zefan
[not found] ` <502DF43F.9010209-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2012-08-17 7:55 ` Daniel Wagner
[not found] ` <1345126336-20755-1-git-send-email-wagi-kQCPcA+X3s7YtjvyW6yDsg@public.gmane.org>
2012-08-16 14:12 ` [PATCH v0 1/5] cgroup: Use empty task_cls_classid() when !CONFIG_NET_CLS(_MODULE) Daniel Wagner
2012-08-16 14:12 ` [PATCH v0 4/5] cgroup: Protect access to task_netprioidx() when built as module Daniel Wagner
2012-08-16 14:12 ` [PATCH v0 5/5] cgroup: Assign subsystem IDs during compile time Daniel Wagner
[not found] ` <1345126336-20755-6-git-send-email-wagi-kQCPcA+X3s7YtjvyW6yDsg@public.gmane.org>
2012-08-16 23:20 ` Tejun Heo
[not found] ` <20120816232010.GJ24861-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-08-17 7:25 ` Li Zefan
2012-08-17 8:48 ` Daniel Wagner [this message]
[not found] ` <502E0552.3080602-kQCPcA+X3s7YtjvyW6yDsg@public.gmane.org>
2012-08-20 17:51 ` Tejun Heo
2012-08-16 19:05 ` [PATCH v0 0/5] " Neil Horman
[not found] ` <20120816190542.GA8203-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2012-08-16 20:25 ` Daniel Wagner
[not found] ` <502D5737.1010604-kQCPcA+X3s7YtjvyW6yDsg@public.gmane.org>
2012-08-16 22:37 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502E0552.3080602@monom.org \
--to=wagi@monom$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=cgroups@vger$(echo .)kernel.org \
--cc=daniel.wagner@bmw-carit$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gaofeng@cn$(echo .)fujitsu.com \
--cc=glommer@parallels$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=john.r.fastabend@intel$(echo .)com \
--cc=kamezawa.hiroyu@jp$(echo .)fujitsu.com \
--cc=lizefan@huawei$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
--cc=tj@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox