From: Stanislav Kinsbursky <skinsbursky@parallels•com>
To: David Miller <davem@davemloft•net>
Cc: "dhowells@redhat•com" <dhowells@redhat•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"rick.jones2@hp•com" <rick.jones2@hp•com>,
"ycheng@google•com" <ycheng@google•com>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
<mikulas@artax•karlin.mff.cuni.cz>
Subject: Re: [PATCH] tun: don't zeroize sock->file on detach
Date: Tue, 21 Aug 2012 20:04:41 +0400 [thread overview]
Message-ID: <5033B199.6080305@parallels.com> (raw)
In-Reply-To: <20120809.161639.1789560369123168415.davem@davemloft.net>
10.08.2012 03:16, David Miller пишет:
> From: Stanislav Kinsbursky <skinsbursky@parallels•com>
> Date: Thu, 09 Aug 2012 16:50:40 +0400
>
>> This is a fix for bug, introduced in 3.4 kernel by commit
>> 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d, which, among other things, replaced
>> simple sock_put() by sk_release_kernel(). Below is sequence, which leads to
>> oops for non-persistent devices:
>>
>> tun_chr_close()
>> tun_detach() <== tun->socket.file = NULL
>> tun_free_netdev()
>> sk_release_sock()
>> sock_release(sock->file == NULL)
>> iput(SOCK_INODE(sock)) <== dereference on NULL pointer
>>
>> This patch just removes zeroing of socket's file from __tun_detach().
>> sock_release() will do this.
>>
>> Cc: stable@vger•kernel.org
>> Reported-by: Ruan Zhijie <ruanzhijie@hotmail•com>
>> Tested-by: Ruan Zhijie <ruanzhijie@hotmail•com>
>> Acked-by: Al Viro <viro@ZenIV•linux.org.uk>
>> Acked-by: Eric Dumazet <edumazet@google•com>
>> Acked-by: Yuchung Cheng <ycheng@google•com>
>> Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels•com>
>
> Applied, thanks.
>
Hi, David.
I found out, that this commit: b09e786bd1dd66418b69348cb110f3a64764626a
was previous attempt to fix the problem.
I believe this commit have to be dropped.
--
Best regards,
Stanislav Kinsbursky
next prev parent reply other threads:[~2012-08-21 16:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 12:50 [PATCH] tun: don't zeroize sock->file on detach Stanislav Kinsbursky
2012-08-09 23:16 ` David Miller
2012-08-21 16:04 ` Stanislav Kinsbursky [this message]
2012-08-21 17:18 ` Neal Cardwell
2012-08-22 9:14 ` Stanislav Kinsbursky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5033B199.6080305@parallels.com \
--to=skinsbursky@parallels$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dhowells@redhat$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mikulas@artax$(echo .)karlin.mff.cuni.cz \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rick.jones2@hp$(echo .)com \
--cc=ycheng@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox