From: Iulius Curt <icurt@ixiacom•com>
To: <sage@inktank•com>
Cc: Iulius Curt <iulius.curt@gmail•com>, <davem@davemloft•net>,
<ceph-devel@vger•kernel.org>, <netdev@vger•kernel.org>,
<dbaluta@ixiacom•com>
Subject: Re: [PATCH v2] libceph: Fix sparse warning
Date: Mon, 27 Aug 2012 15:20:52 +0300 [thread overview]
Message-ID: <503B6624.5000408@ixiacom.com> (raw)
In-Reply-To: <1345724069-12405-1-git-send-email-icurt@ixiacom.com>
On 08/23/2012 03:14 PM, Iulius Curt wrote:
> From: Iulius Curt<iulius.curt@gmail•com>
>
> Make ceph_monc_do_poolop() static to remove the following sparse warning:
> * net/ceph/mon_client.c:616:5: warning: symbol 'ceph_monc_do_poolop' was not
> declared. Should it be static?
> Also drops the 'ceph_monc_' prefix, now being a private function.
>
> Signed-off-by: Iulius Curt<icurt@ixiacom•com>
> ---
> v1 ---> v2
> * drop the 'ceph_monc_' prefix
> ---
> net/ceph/mon_client.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/ceph/mon_client.c b/net/ceph/mon_client.c
> index 105d533..84ce495 100644
> --- a/net/ceph/mon_client.c
> +++ b/net/ceph/mon_client.c
> @@ -613,7 +613,7 @@ bad:
> /*
> * Do a synchronous pool op.
> */
> -int ceph_monc_do_poolop(struct ceph_mon_client *monc, u32 op,
> +static int do_poolop(struct ceph_mon_client *monc, u32 op,
> u32 pool, u64 snapid,
> char *buf, int len)
> {
> @@ -663,7 +663,7 @@ out:
> int ceph_monc_create_snapid(struct ceph_mon_client *monc,
> u32 pool, u64 *snapid)
> {
> - return ceph_monc_do_poolop(monc, POOL_OP_CREATE_UNMANAGED_SNAP,
> + return do_poolop(monc, POOL_OP_CREATE_UNMANAGED_SNAP,
> pool, 0, (char *)snapid, sizeof(*snapid));
>
> }
> @@ -672,7 +672,7 @@ EXPORT_SYMBOL(ceph_monc_create_snapid);
> int ceph_monc_delete_snapid(struct ceph_mon_client *monc,
> u32 pool, u64 snapid)
> {
> - return ceph_monc_do_poolop(monc, POOL_OP_CREATE_UNMANAGED_SNAP,
> + return do_poolop(monc, POOL_OP_CREATE_UNMANAGED_SNAP,
> pool, snapid, 0, 0);
>
> }
> --
> 1.7.9.5
>
>
Hi Sage,
Can you, please, have a look.
Thanks,
Iulius
next prev parent reply other threads:[~2012-08-27 12:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 12:14 [PATCH v2] libceph: Fix sparse warning Iulius Curt
2012-08-27 12:20 ` Iulius Curt [this message]
2012-08-27 16:04 ` Sage Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503B6624.5000408@ixiacom.com \
--to=icurt@ixiacom$(echo .)com \
--cc=ceph-devel@vger$(echo .)kernel.org \
--cc=davem@davemloft$(echo .)net \
--cc=dbaluta@ixiacom$(echo .)com \
--cc=iulius.curt@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sage@inktank$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox