From: Nicolas Dichtel <nicolas.dichtel@6wind•com>
To: Vlad Yasevich <vyasevich@gmail•com>
Cc: sri@us•ibm.com, linux-sctp@vger•kernel.org, netdev@vger•kernel.org
Subject: Re: [PATCH] sctp: check dst validity after IPsec operations
Date: Fri, 07 Sep 2012 14:07:05 +0200 [thread overview]
Message-ID: <5049E369.9060901@6wind.com> (raw)
In-Reply-To: <5048C984.3030306@gmail.com>
Le 06/09/2012 18:04, Vlad Yasevich a écrit :
> On 09/06/2012 01:40 PM, Nicolas Dichtel wrote:
>> dst stored in struct sctp_transport needs to be recalculated when ipsec policy
>> are updated. We use flow_cache_genid for that.
>>
>> For example, if a SCTP connection is established and then an IPsec policy is
>> set, the old SCTP flow will not be updated and thus will not use the new
>> IPsec policy.
>>
>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind•com>
>
> why doesn't this need to be done for TCP? What makes SCTP special in this case?
>
> ip_queue_xmit does an __sk_dst_check() which is essentially what
> sctp_transport_dst_check() does. That should determine if the currently cached
> route is valid or not.
>
> Looks like sctp may need to change to using ip_route_output_ports() call
> as ip_route_output_key may not do all that is necessary
I try, but it doesn't solve the problem. In fact, it seems better to use
ip_route_output_ports(), would you like me to send a patch?
Regards,
Nicolas
next prev parent reply other threads:[~2012-09-07 12:07 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 17:40 [PATCH] sctp: check dst validity after IPsec operations Nicolas Dichtel
2012-09-06 16:04 ` Vlad Yasevich
2012-09-06 16:40 ` Nicolas Dichtel
2012-09-06 17:03 ` Vlad Yasevich
2012-09-07 12:24 ` Nicolas Dichtel
2012-09-07 12:07 ` Nicolas Dichtel [this message]
2012-09-06 18:10 ` David Miller
2012-09-07 13:47 ` Nicolas Dichtel
2012-09-07 15:57 ` [PATCH RFC net-next 0/2] Take care of xfrm policy when checking dst entries Nicolas Dichtel
2012-09-07 15:57 ` [PATCH 1/2] dst: take into account policy update on check() Nicolas Dichtel
2012-09-07 14:20 ` Vlad Yasevich
2012-09-07 14:35 ` Eric Dumazet
2012-09-07 14:47 ` Nicolas Dichtel
2012-09-07 15:09 ` Eric Dumazet
2012-09-07 15:13 ` Nicolas Dichtel
2012-09-07 15:21 ` Eric Dumazet
2012-09-07 18:48 ` David Miller
2012-09-07 18:48 ` David Miller
2012-09-10 12:47 ` Nicolas Dichtel
2012-09-10 13:10 ` Eric Dumazet
2012-09-10 13:22 ` [PATCH net-next v2] Take care of xfrm policy when checking dst entries Nicolas Dichtel
2012-09-10 13:22 ` [PATCH net-next v2 1/4] netns: move net->ipv4.rt_genid to net->rt_genid Nicolas Dichtel
2012-09-10 13:22 ` [PATCH net-next v2 2/4] xfrm: invalidate dst on policy insertion/deletion Nicolas Dichtel
2012-09-10 14:21 ` Vlad Yasevich
2012-09-10 14:56 ` Nicolas Dichtel
2012-09-11 8:09 ` [PATCH net-next v3 0/4] Take care of xfrm policy when checking dst entries Nicolas Dichtel
2012-09-11 8:09 ` [PATCH net-next v3 1/4] netns: move net->ipv4.rt_genid to net->rt_genid Nicolas Dichtel
2012-09-11 8:09 ` [PATCH net-next v3 2/4] xfrm: invalidate dst on policy insertion/deletion Nicolas Dichtel
2012-09-11 8:09 ` [PATCH net-next v3 3/4] ipv6: use net->rt_genid to check dst validity Nicolas Dichtel
2012-09-11 8:09 ` [PATCH net-next v3 4/4] ipv6: use DST_* macro to set obselete field Nicolas Dichtel
2012-09-12 7:40 ` Eric Dumazet
2012-09-17 16:49 ` [PATCH net-next v3 0/4] Take care of xfrm policy when checking dst entries David Miller
2012-09-17 18:14 ` Vlad Yasevich
2012-09-17 18:25 ` David Miller
2012-09-17 19:52 ` Nicolas Dichtel
2012-09-17 19:54 ` David Miller
2012-09-18 20:08 ` David Miller
2012-09-10 13:22 ` [PATCH net-next v2 3/4] ipv6: use net->rt_genid to check dst validity Nicolas Dichtel
2012-09-10 14:29 ` Vlad Yasevich
2012-09-10 14:34 ` Nicolas Dichtel
2012-09-10 14:43 ` Vlad Yasevich
2012-09-10 14:44 ` Nicolas Dichtel
2012-09-10 13:22 ` [PATCH net-next v2 4/4] ipv6: use DST_* macro to set obselete field Nicolas Dichtel
2012-09-10 14:35 ` [PATCH net-next v2] Take care of xfrm policy when checking dst entries Vlad Yasevich
2012-09-10 14:38 ` Nicolas Dichtel
2012-09-10 17:18 ` David Miller
2012-09-10 17:59 ` Vlad Yasevich
2012-09-10 18:01 ` David Miller
2012-09-22 16:49 ` Jan Engelhardt
2012-09-07 14:51 ` [PATCH 1/2] dst: take into account policy update on check() Vlad Yasevich
2012-09-07 15:08 ` Eric Dumazet
2012-09-07 15:57 ` [PATCH 2/2] ipv6: remove rt6i_flow_cache_genid field in rt6_info Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5049E369.9060901@6wind.com \
--to=nicolas.dichtel@6wind$(echo .)com \
--cc=linux-sctp@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sri@us$(echo .)ibm.com \
--cc=vyasevich@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox