From: Daniel Wagner <wagi@monom•org>
To: Tejun Heo <tj@kernel•org>
Cc: netdev@vger•kernel.org, cgroups@vger•kernel.org,
Daniel Wagner <daniel.wagner@bmw-carit•de>,
"David S. Miller" <davem@davemloft•net>,
Andrew Morton <akpm@linux-foundation•org>,
Eric Dumazet <edumazet@google•com>,
Gao feng <gaofeng@cn•fujitsu.com>,
Glauber Costa <glommer@parallels•com>,
Jamal Hadi Salim <jhs@mojatatu•com>,
John Fastabend <john.r.fastabend@intel•com>,
Kamezawa Hiroyuki <kamezawa.hiroyu@jp•fujitsu.com>,
Li Zefan <lizefan@huawei•com>,
Neil Horman <nhorman@tuxdriver•com>
Subject: Re: [PATCH v3 7/8] cgroup: Assign subsystem IDs during compile time
Date: Tue, 11 Sep 2012 23:31:45 +0200 [thread overview]
Message-ID: <504FADC1.4060503@monom.org> (raw)
In-Reply-To: <20120911210821.GB7677@google.com>
On 09/11/2012 11:08 PM, Tejun Heo wrote:
> On Tue, Sep 11, 2012 at 02:01:09PM -0700, Tejun Heo wrote:
>> For example, it's not evident the above is correct and it's burried
>> with all other changes. Can't we just assign the fixed subsys ID to
>> net_prio_subsys_id in this patch? This patch would be correct without
>> any netprio changes, no?
>
> Oops, that was wrong. net_prio_subsys_id itself becomes constant.
> Let's please better explain why the RCU trick removal is safe then.
In the last paragraph in the commit message I tried to document why it
is safe to remove the RCU trick. Not good enough?
next prev parent reply other threads:[~2012-09-11 21:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 16:26 [PATCH v3 0/8] cgroup: Assign subsystem IDs during compile time Daniel Wagner
2012-09-11 16:26 ` [PATCH v3 1/8] cgroup: net_cls: Move sock_update_classid() declaration to cls_cgroup.h Daniel Wagner
2012-09-11 16:26 ` [PATCH v3 2/8] cgroup: net_cls: Do not define task_cls_classid() when not selected Daniel Wagner
2012-09-11 16:26 ` [PATCH v3 3/8] cgroup: net_prio: Do not define task_netpioidx() " Daniel Wagner
[not found] ` <1347380774-9546-4-git-send-email-wagi-kQCPcA+X3s7YtjvyW6yDsg@public.gmane.org>
2012-09-11 20:37 ` Tejun Heo
2012-09-11 16:26 ` [PATCH v3 5/8] cgroup: Wrap subsystem selection macro Daniel Wagner
[not found] ` <1347380774-9546-1-git-send-email-wagi-kQCPcA+X3s7YtjvyW6yDsg@public.gmane.org>
2012-09-11 16:26 ` [PATCH v3 4/8] cgroup: Remove CGROUP_BUILTIN_SUBSYS_COUNT Daniel Wagner
[not found] ` <1347380774-9546-5-git-send-email-wagi-kQCPcA+X3s7YtjvyW6yDsg@public.gmane.org>
2012-09-11 20:41 ` Tejun Heo
2012-09-11 16:26 ` [PATCH v3 6/8] cgroup: Do not depend on a given order when populating the subsys array Daniel Wagner
2012-09-11 16:26 ` [PATCH v3 7/8] cgroup: Assign subsystem IDs during compile time Daniel Wagner
2012-09-11 21:01 ` Tejun Heo
[not found] ` <20120911210109.GZ7677-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-11 21:08 ` Tejun Heo
2012-09-11 21:31 ` Daniel Wagner [this message]
[not found] ` <504FADC1.4060503-kQCPcA+X3s7YtjvyW6yDsg@public.gmane.org>
2012-09-11 21:36 ` Tejun Heo
[not found] ` <20120911213646.GF7677-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-11 21:39 ` Daniel Wagner
2012-09-11 21:15 ` Daniel Wagner
2012-09-11 21:27 ` Tejun Heo
[not found] ` <1347380774-9546-8-git-send-email-wagi-kQCPcA+X3s7YtjvyW6yDsg@public.gmane.org>
2012-09-11 21:04 ` Tejun Heo
[not found] ` <20120911210435.GA7677-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-11 21:15 ` Daniel Wagner
2012-09-11 16:26 ` [PATCH v3 8/8] cgroup: Define CGROUP_SUBSYS_COUNT according the configuration Daniel Wagner
2012-09-11 21:11 ` [PATCH v3 0/8] cgroup: Assign subsystem IDs during compile time Tejun Heo
[not found] ` <20120911211151.GC7677-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-11 21:19 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504FADC1.4060503@monom.org \
--to=wagi@monom$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=cgroups@vger$(echo .)kernel.org \
--cc=daniel.wagner@bmw-carit$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gaofeng@cn$(echo .)fujitsu.com \
--cc=glommer@parallels$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=john.r.fastabend@intel$(echo .)com \
--cc=kamezawa.hiroyu@jp$(echo .)fujitsu.com \
--cc=lizefan@huawei$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
--cc=tj@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox