Subject: Re: [PATCH v4 3/8] cgroup: net_prio: Do not define task_netpioidx() when not selected

From: Li Zefan <[email-masked]>
Date: Thu, 13 Sep 2012 14:36:13 +0800

On 2012/9/12 22:12, Daniel Wagner wrote:
> From: Daniel Wagner <[email-masked]>
> 
> task_netprioidx() should not be defined in case the configuration is
> CONFIG_NETPRIO_CGROUP=n. The reason is that in a following patch the
> net_prio_subsys_id will only be defined if CONFIG_NETPRIO_CGROUP!=n.
> When net_prio is not built at all any callee should only get an empty
> task_netprioidx() without any references to net_prio_subsys_id.
> 
> Signed-off-by: Daniel Wagner <[email-masked]>
> Acked-by: Tejun Heo <[email-masked]>
> Cc: Gao feng <[email-masked]>
> Cc: Jamal Hadi Salim <jhs-jkUAjuhPggJWk0Htik3J/[email-masked]>
> Cc: John Fastabend <[email-masked]>
> Cc: Li Zefan <[email-masked]>
> Cc: Neil Horman <[email-masked]>
> Cc: [email-masked]
> Cc: [email-masked]

Acked-by: Li Zefan <[email-masked]>

> ---
>  include/net/netprio_cgroup.h | 12 +++++-------
>  net/core/sock.c              |  2 ++
>  2 files changed, 7 insertions(+), 7 deletions(-)