From: Larry Finger <Larry.Finger@lwfinger•net>
To: Jarl Friis <jarl@softace•dk>
Cc: "Stefano Brivio" <stefano.brivio@polimi•it>,
"Gábor Stefanik" <netrolller.3d@gmail•com>,
netdev@vger•kernel.org, linux-wireless@vger•kernel.org,
b43-dev@lists•infradead.org
Subject: Re: [PATCH 2/2] Using LP firmware for taking advantage of the low-power capabilities.
Date: Wed, 19 Sep 2012 10:08:33 -0500 [thread overview]
Message-ID: <5059DFF1.4060405@lwfinger.net> (raw)
In-Reply-To: <1348053493-22955-2-git-send-email-jarl@softace.dk>
On 09/19/2012 06:18 AM, Jarl Friis wrote:
> This is using the LP specific firmware to better take advantage of the
> Low-Power capabilities.
>
> Signed-off-by: Jarl Friis <jarl@softace•dk>
> ---
> drivers/net/wireless/b43/main.c | 16 ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
> index 202a0eb..9ee6030 100644
> --- a/drivers/net/wireless/b43/main.c
> +++ b/drivers/net/wireless/b43/main.c
> @@ -8,6 +8,7 @@
> Copyright (c) 2005 Danny van Dyk <kugelfang@gentoo•org>
> Copyright (c) 2005 Andreas Jaggi <andreas.jaggi@waterwave•ch>
> Copyright (c) 2010-2011 Rafał Miłecki <zajec5@gmail•com>
> + Copyright (c) 2012 Jarl Friis <jarl@softace•dk>
>
> SDIO support
> Copyright (c) 2009 Albert Herranz <albert_herranz@yahoo•es>
> @@ -72,6 +73,7 @@ MODULE_FIRMWARE("b43/ucode11.fw");
> MODULE_FIRMWARE("b43/ucode13.fw");
> MODULE_FIRMWARE("b43/ucode14.fw");
> MODULE_FIRMWARE("b43/ucode15.fw");
> +MODULE_FIRMWARE("b43/ucode16_lp.fw");
> MODULE_FIRMWARE("b43/ucode16_mimo.fw");
> MODULE_FIRMWARE("b43/ucode5.fw");
> MODULE_FIRMWARE("b43/ucode9.fw");
> @@ -2208,6 +2210,12 @@ static int b43_try_request_fw(struct b43_request_fw_context *ctx)
> else
> goto err_no_ucode;
> break;
> + case B43_PHYTYPE_LP:
> + if (rev >= 16)
> + filename = "ucode16_lp";
> + else
> + goto err_no_ucode;
> + break;
> case B43_PHYTYPE_HT:
> if (rev == 29)
> filename = "ucode29_mimo";
> @@ -2277,8 +2285,10 @@ static int b43_try_request_fw(struct b43_request_fw_context *ctx)
> filename = "lp0initvals13";
> else if (rev == 14)
> filename = "lp0initvals14";
> - else if (rev >= 15)
> + else if (rev == 15)
> filename = "lp0initvals15";
> + else if (rev >= 16)
> + filename = "lp0initvals16";
> else
> goto err_no_initvals;
> break;
> @@ -2336,8 +2346,10 @@ static int b43_try_request_fw(struct b43_request_fw_context *ctx)
> filename = "lp0bsinitvals13";
> else if (rev == 14)
> filename = "lp0bsinitvals14";
> - else if (rev >= 15)
> + else if (rev == 15)
> filename = "lp0bsinitvals15";
> + else if (rev >= 16)
> + filename = "lp0bsinitvals16";
> else
> goto err_no_initvals;
> break;
I have some questions about this patch. Where did you get the information needed
to make these changes? Did it come from reverse engineering some Broadcom code,
or did you look at their actual code? There is a great deal of difference
relative to our "clean-room" status. Anyone that has seen non-GPL Broadcom
material cannot contribute code to b43.
Have you tested this code on devices with rev>=16?
Now for some comments: This patch also needs the "b43:" added to the subject. In
addition, you appear to have at least one white-space error in the
MODULE_FIRMWARE line. Is the addition of your copyright to the driver warranted
by this change? For example, I have made much larger contributions to b43 over
the years before I started doing reverse-engineering on this driver, but I never
added my copyright. Your "Signed-off-by" implies copyright for the patch.
Larry
next prev parent reply other threads:[~2012-09-19 15:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 11:18 [PATCH 1/2] Added information about which firmware file is being requested Jarl Friis
2012-09-19 11:18 ` [PATCH 2/2] Using LP firmware for taking advantage of the low-power capabilities Jarl Friis
2012-09-19 15:08 ` Larry Finger [this message]
[not found] ` <5059DFF1.4060405-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2012-09-19 18:54 ` Jarl Friis
[not found] ` <CAOjsGA25PR9OCC_cAVn=gztk9YB6pNxCz=1mFjDxxQoc-tofEw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-09-19 19:33 ` Arend van Spriel
2012-09-19 19:40 ` Jarl Friis
[not found] ` <1348053493-22955-2-git-send-email-jarl-bE7lSbLpGj1/SzgSGea1oA@public.gmane.org>
2012-09-19 20:10 ` Jarl Friis
2012-09-20 6:05 ` Rafał Miłecki
[not found] ` <CACna6ryRXB6GjymaP-RM8HTEeWRHnE8B=5tdH3J4JGyeHBEE6Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-09-20 6:32 ` Jarl Friis
[not found] ` <1348053493-22955-1-git-send-email-jarl-bE7lSbLpGj1/SzgSGea1oA@public.gmane.org>
2012-09-19 12:39 ` [PATCH 1/2] Added information about which firmware file is being requested Julian Calaby
2012-09-19 18:42 ` Michael Tokarev
[not found] ` <505A1206.4020606-Gdu+ltImwkhes2APU0mLOQ@public.gmane.org>
2012-09-19 18:56 ` Jarl Friis
2012-09-20 6:06 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5059DFF1.4060405@lwfinger.net \
--to=larry.finger@lwfinger$(echo .)net \
--cc=b43-dev@lists$(echo .)infradead.org \
--cc=jarl@softace$(echo .)dk \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netrolller.3d@gmail$(echo .)com \
--cc=stefano.brivio@polimi$(echo .)it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox