From: Wolfgang Grandegger <wg@grandegger•com>
To: Wei Yongjun <weiyj.lk@gmail•com>
Cc: mkl@pengutronix•de, grant.likely@secretlab•ca,
rob.herring@calxeda•com, yongjun_wei@trendmicro•com.cn,
linux-can@vger•kernel.org, netdev@vger•kernel.org,
devicetree-discuss@lists•ozlabs.org
Subject: Re: [PATCH] can: mscan-mpc5xxx: fix return value check in mpc512x_can_get_clock()
Date: Fri, 21 Sep 2012 09:14:08 +0200 [thread overview]
Message-ID: <505C13C0.8090200@grandegger.com> (raw)
In-Reply-To: <CAPgLHd9fRAvQ77rD_PCp45XW9-FsBisUATOT00Je39nbv5o28A@mail.gmail.com>
On 09/21/2012 09:09 AM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro•com.cn>
>
> In case of error, the function clk_get() returns ERR_PTR()
> and never returns NULL pointer. The NULL test in the error
> handling should be replaced with IS_ERR().
>
> dpatch engine is used to auto generated this patch.
> (https://github.com/weiyj/dpatch)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro•com.cn>
Acked-by: Wolfgang Grandegger <wg@grandegger•com>
Thanks,
Wolfgang.
next prev parent reply other threads:[~2012-09-21 7:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 7:09 [PATCH] can: mscan-mpc5xxx: fix return value check in mpc512x_can_get_clock() Wei Yongjun
2012-09-21 7:14 ` Wolfgang Grandegger [this message]
2012-09-21 8:09 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505C13C0.8090200@grandegger.com \
--to=wg@grandegger$(echo .)com \
--cc=devicetree-discuss@lists$(echo .)ozlabs.org \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=linux-can@vger$(echo .)kernel.org \
--cc=mkl@pengutronix$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rob.herring@calxeda$(echo .)com \
--cc=weiyj.lk@gmail$(echo .)com \
--cc=yongjun_wei@trendmicro$(echo .)com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox