public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Gao feng <gaofeng@cn•fujitsu.com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: Jan Engelhardt <jengelh@inai•de>,
	Stephen Hemminger <stephen.hemminger@vyatta•com>,
	netdev@vger•kernel.org, davem@davemloft•net,
	kuznet@ms2•inr.ac.ru
Subject: Re: [PATCH] inet_diag: make config INET_DIAG bool
Date: Tue, 25 Sep 2012 10:18:17 +0800	[thread overview]
Message-ID: <50611469.4000409@cn.fujitsu.com> (raw)
In-Reply-To: <1348486346.26828.511.camel@edumazet-glaptop>

于 2012年09月24日 19:32, Eric Dumazet 写道:
> On Mon, 2012-09-24 at 18:17 +0800, Gao feng wrote:
>> 于 2012年09月24日 17:42, Eric Dumazet 写道:
>>> In fact I didnt fully understand the problem you try to address.
>>>
>>> If you want to prevent module being unloaded, you need to add proper
>>> module_get()/module_put()
>>>
>>> So I would add a "struct module *module;" in struct sock_diag_handler
>>> and use it appropriately.
>>
>> Yes, I try to add reference of the module,but I can't find a proper
>> location to call module_get and module_put.
>>
>> module_get should be called when userspace program use netlink to
>> send dump request to the kernel,and module_put should be called when
>> the dump is completed. I am right?
>>
>> BUT the userspace program may only call netlink_sendmsg without call
>> netlink_recvmsg.so the reference of the module will be incorrect.
> 
> check ->dump() and ->done() methods
> 

I miss that cb->done will be called when netlink sock being destructed.
so add a reference of the inet_diag module is doable.

I will send a v2 patch.

Thanks!

     prev parent reply	other threads:[~2012-09-25  2:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-23  3:49 [PATCH] inet_diag: make config INET_DIAG bool Gao feng
2012-09-23  4:36 ` Stephen Hemminger
2012-09-23 13:40   ` Jan Engelhardt
2012-09-24  8:48     ` Gao feng
2012-09-24  9:42       ` Eric Dumazet
2012-09-24 10:17         ` Gao feng
2012-09-24 11:32           ` Eric Dumazet
2012-09-25  2:18             ` Gao feng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50611469.4000409@cn.fujitsu.com \
    --to=gaofeng@cn$(echo .)fujitsu.com \
    --cc=davem@davemloft$(echo .)net \
    --cc=eric.dumazet@gmail$(echo .)com \
    --cc=jengelh@inai$(echo .)de \
    --cc=kuznet@ms2$(echo .)inr.ac.ru \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=stephen.hemminger@vyatta$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox