Subject: Re: [PATCH] sctp: fix call to SCTP_CMD_PROCESS_SACK in sctp_cmd_interpreter()

From: Vlad Yasevich <[email-masked]>
Date: Mon, 15 Oct 2012 11:40:38 -0400

On 10/15/2012 09:56 AM, [email-masked] wrote:
> From: Zijie Pan <[email-masked]>
>
> Bug introduced by commit edfee0339e681a784ebacec7e8c2dc97dc6d2839
> (sctp: check src addr when processing SACK to update transport state)
>
> Signed-off-by: Zijie Pan <[email-masked]>
> Signed-off-by: Nicolas Dichtel <[email-masked]>

Shutdown case..  ACK.

Acked-by: Vlad Yasevich <[email-masked]>

> ---
>   net/sctp/sm_sideeffect.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
> index 57f7de8..6773d78 100644
> --- a/net/sctp/sm_sideeffect.c
> +++ b/net/sctp/sm_sideeffect.c
> @@ -1642,8 +1642,9 @@ static int sctp_cmd_interpreter(sctp_event_t event_type,
>   					asoc->outqueue.outstanding_bytes;
>   			sackh.num_gap_ack_blocks = 0;
>   			sackh.num_dup_tsns = 0;
> +			chunk->subh.sack_hdr = &sackh;
>   			sctp_add_cmd_sf(commands, SCTP_CMD_PROCESS_SACK,
> -					SCTP_SACKH(&sackh));
> +					SCTP_CHUNK(chunk));
>   			break;
>
>   		case SCTP_CMD_DISCARD_PACKET:
>