Subject: Re: [PATCH net-next] packet mmap : allow the user to choose tx data offset.

From: Paul Chavent <[email-masked]>
Date: Fri, 19 Oct 2012 15:50:18 +0200

There is a point where I'm wrong in my last reply :

On 10/19/2012 01:36 PM, Daniel Borkmann wrote:
>> +               int off;
>
> For offsets, better use off_t, or here u32. Also, add a newline after
> variable declaration.

i use int because of arithmetics :
off_max = po->tx_ring.frame_size - tp_len;

If the user give a bad tp_len (> po->tx_ring.frame_size), with unsigned 
we will probably miss the check that follow :
		
if (unlikely((off < off_min) || (off_max < off)))