From: Pavel Emelyanov <xemul@parallels•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: Brian Haley <brian.haley@hp•com>,
Linux Netdev List <netdev@vger•kernel.org>,
David Miller <davem@davemloft•net>
Subject: Re: [PATCH net-next] sockopt: Make SO_BINDTODEVICE readable
Date: Tue, 23 Oct 2012 01:10:22 +0400 [thread overview]
Message-ID: <5085B63E.5070504@parallels.com> (raw)
In-Reply-To: <1350938702.8609.1299.camel@edumazet-glaptop>
On 10/23/2012 12:45 AM, Eric Dumazet wrote:
> On Mon, 2012-10-22 at 14:04 -0400, Brian Haley wrote:
>
>> + char devname[IFNAMSIZ];
>> +
>> + ret = 0;
>> + if (sk->sk_bound_dev_if == 0)
>> + goto out;
>> +
>> + ret = -EINVAL;
>> + if (len < IFNAMSIZ)
>> + goto out;
>> + if (len > IFNAMSIZ)
>> + len = IFNAMSIZ;
>> +
>> + rcu_read_lock();
>> + dev = dev_get_by_index_rcu(net, sk->sk_bound_dev_if);
>> + if (dev)
>> + strcpy(dev->name, devname);
>> + rcu_read_unlock();
>> + ret = -ENODEV;
>
> You probably meant
>
> strcpy(devname, dev->name)
>
> By the way, this is not really safe in case device is renamed
Good point, actually. Getting a device name may be not very safe in terms of --
once we have the name there's no 100% guarantee, that this name corresponds to the
actual device the socket is bound to (it could be renamed after we strcpy-ed its
name). This problem doesn't exist when we get device index, as it cannot be changed.
Thanks,
Pavel
next prev parent reply other threads:[~2012-10-22 21:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 9:55 [PATCH net-next] sockopt: Make SO_BINDTODEVICE readable Pavel Emelyanov
2012-10-19 10:34 ` Eric Dumazet
2012-10-22 0:43 ` David Miller
2012-10-22 10:20 ` Pavel Emelyanov
2012-10-22 18:04 ` Brian Haley
2012-10-22 20:28 ` Pavel Emelyanov
2012-10-22 21:23 ` Brian Haley
2012-10-22 20:45 ` Eric Dumazet
2012-10-22 21:10 ` Pavel Emelyanov [this message]
2012-10-22 21:20 ` Brian Haley
2012-10-22 21:37 ` Eric Dumazet
2012-10-22 21:47 ` Brian Haley
2012-10-22 21:52 ` Eric Dumazet
2012-10-22 21:58 ` Ben Hutchings
2012-10-23 21:43 ` Brian Haley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5085B63E.5070504@parallels.com \
--to=xemul@parallels$(echo .)com \
--cc=brian.haley@hp$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox