Subject: Re: [PATCH] vlan: set sysfs device_type to 'vlan'

From: Ben Greear <[email-masked]>
Date: Tue, 23 Oct 2012 09:14:14 -0700

On 10/22/2012 11:36 PM, David Miller wrote:
> From: Doug Goldstein <[email-masked]>
> Date: Mon, 22 Oct 2012 00:53:57 -0500
>
>> Sets the sysfs device_type to 'vlan' for udev. This makes it easier for
>> applications that query network information via udev to identify vlans
>> instead of using strrchr().
>>
>> Signed-off-by: Doug Goldstein <[email-masked]>
>
> You're extremely misguided.  This change, in fact, makes it ten times
> harder for such applications to query such devices.

If the application doesn't care, it can use the old way (which at least
for me, involves string-comparing the driver name ethtool returns, which
sucks at best).

And applications that care might suddenly have more features, or be more
efficient when running on newer kernels..

Thanks,
Ben

-- 
Ben Greear <[email-masked]>
Candela Technologies Inc  http://www.candelatech.com