From: Roland Stigge <stigge@antcom•de>
To: Peter Senna Tschudin <peter.senna@gmail•com>
Cc: davem@davemloft•net, edumazet@google•com, djduanjiong@gmail•com,
aletes.xgr@gmail•com, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, kernel-janitors@vger•kernel.org
Subject: Re: [PATCH 1/2] drivers/net/ethernet/nxp/lpc_eth.c: Call mdiobus_unregister before mdiobus_free
Date: Sun, 28 Oct 2012 18:44:55 +0100 [thread overview]
Message-ID: <508D6F17.4000405@antcom.de> (raw)
In-Reply-To: <1351440721-9121-1-git-send-email-peter.senna@gmail.com>
On 28/10/12 17:12, Peter Senna Tschudin wrote:
> Based on commit b27393aecf66199f5ddad37c302d3e0cfadbe6c0
>
> Calling mdiobus_free without calling mdiobus_unregister causes
> BUG_ON(). This patch fixes the issue.
>
> The semantic patch that found this issue(http://coccinelle.lip6.fr/):
> // <smpl>
> @@
> expression E;
> @@
> ... when != mdiobus_unregister(E);
>
> + mdiobus_unregister(E);
> mdiobus_free(E);
> // </smpl>
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail•com>
Tested-by: Roland Stigge <stigge@antcom•de>
Thanks for the patch!
Roland
> ---
> This problem is somewhat mystifying. If the patch is correct, there were
> probably many OOPSese caused by not calling mdiobus_unregister...
> Reporting anyway...
>
> drivers/net/ethernet/nxp/lpc_eth.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c
> index 53743f7..af8b414 100644
> --- a/drivers/net/ethernet/nxp/lpc_eth.c
> +++ b/drivers/net/ethernet/nxp/lpc_eth.c
> @@ -1524,6 +1524,7 @@ static int lpc_eth_drv_remove(struct platform_device *pdev)
> pldat->dma_buff_base_p);
> free_irq(ndev->irq, ndev);
> iounmap(pldat->net_base);
> + mdiobus_unregister(pldat->mii_bus);
> mdiobus_free(pldat->mii_bus);
> clk_disable(pldat->clk);
> clk_put(pldat->clk);
next prev parent reply other threads:[~2012-10-28 17:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-28 16:12 [PATCH 1/2] drivers/net/ethernet/nxp/lpc_eth.c: Call mdiobus_unregister before mdiobus_free Peter Senna Tschudin
2012-10-28 16:12 ` [PATCH 2/2] drivers/net/phy/mdio-bitbang.c: " Peter Senna Tschudin
2012-11-03 1:36 ` David Miller
2012-10-28 17:44 ` Roland Stigge [this message]
2012-10-29 11:58 ` [PATCH 1/2] drivers/net/ethernet/nxp/lpc_eth.c: " Alexandre Pereira da Silva
2012-11-03 1:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508D6F17.4000405@antcom.de \
--to=stigge@antcom$(echo .)de \
--cc=aletes.xgr@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=djduanjiong@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=kernel-janitors@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peter.senna@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox