From: Nicolas Dichtel <nicolas.dichtel@6wind•com>
To: davem@davemloft•net
Cc: fengguang.wu@intel•com, netdev@vger•kernel.org
Subject: Re: [PATCH net-next] ipv6: remove useless test in dev_forward_change()
Date: Mon, 29 Oct 2012 11:07:39 +0100 [thread overview]
Message-ID: <508E556B.8030602@6wind.com> (raw)
In-Reply-To: <1351502649-3876-1-git-send-email-nicolas.dichtel@6wind.com>
Please ignore, the patch has already be sent by Cong Wang <amwang@redhat•com>.
Le 29/10/2012 10:24, Nicolas Dichtel a écrit :
> idev->dev cannot be NULL.
>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind•com>
> ---
> net/ipv6/addrconf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index 8f0b12a..c9b1cf3 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -607,7 +607,7 @@ static void dev_forward_change(struct inet6_dev *idev)
> dev = idev->dev;
> if (idev->cnf.forwarding)
> dev_disable_lro(dev);
> - if (dev && (dev->flags & IFF_MULTICAST)) {
> + if (dev->flags & IFF_MULTICAST) {
> if (idev->cnf.forwarding)
> ipv6_dev_mc_inc(dev, &in6addr_linklocal_allrouters);
> else
>
prev parent reply other threads:[~2012-10-29 10:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <508ddd10.Fq4xdOIJOPuT2J+A%yuanhan.liu@linux.intel.com>
2012-10-29 1:57 ` [net-next:master 86/92] net/ipv6/addrconf.c:557 dev_forward_change() error: we previously assumed 'dev' could be null (see line 541) Fengguang Wu
2012-10-29 9:24 ` [PATCH net-next] ipv6: remove useless test in dev_forward_change() Nicolas Dichtel
2012-10-29 9:22 ` Cong Wang
2012-10-29 9:31 ` Eric Dumazet
2012-10-29 10:07 ` Nicolas Dichtel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508E556B.8030602@6wind.com \
--to=nicolas.dichtel@6wind$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=fengguang.wu@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox