From: Daniel Lezcano <daniel.lezcano@linaro•org>
To: Viresh Kumar <viresh.kumar@linaro•org>
Cc: Ben Hutchings <bhutchings@solarflare•com>,
netdev@vger•kernel.org, linaro-dev@lists•linaro.org,
davem@davemloft•net, linux-kernel@vger•kernel.org,
patches@linaro•org
Subject: Re: [PATCH] net: dsa/slave: Fix compilation warnings
Date: Tue, 30 Oct 2012 11:04:57 +0100 [thread overview]
Message-ID: <508FA649.6090901@linaro.org> (raw)
In-Reply-To: <CAKohpo=X0ZNSRZHFO==j43Hq0ZheQLmER9X+adsLQErAJT5f2w@mail.gmail.com>
On 10/30/2012 10:45 AM, Viresh Kumar wrote:
> On 30 October 2012 14:56, Daniel Lezcano <daniel.lezcano@linaro•org> wrote:
>> Well, it is the same here, no ? Except, it is up to the user to disable
>> the option.
>
> I didn't wanted to add code like this:
>
>>> + select NET_DSA_TAG_DSA if (!NET_DSA_TAG_EDSA &&
>>> !NET_DSA_TAG_TRAILER)
>
> Why should we select NET_DSA_TAG_DSA by default? What made us
> select that?
That was an example, like you I don't know the DSA at all.
I guess the maintainer will guide on that.
> For this reason, i went to the solution i offered.
Ok.
> Anyway, i just wanted to get rid of the warning. Whatever maintainer
> feels is better must be selected.
Yep.
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2012-10-30 10:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 16:57 [PATCH] net: dsa/slave: Fix compilation warnings Viresh Kumar
2012-10-29 19:59 ` Ben Hutchings
2012-10-30 6:45 ` Viresh Kumar
2012-10-30 7:31 ` Viresh Kumar
2012-10-30 7:53 ` Daniel Lezcano
2012-10-30 7:55 ` Viresh Kumar
2012-10-30 9:00 ` Daniel Lezcano
2012-10-30 9:03 ` Viresh Kumar
2012-10-30 9:26 ` Daniel Lezcano
2012-10-30 9:45 ` Viresh Kumar
2012-10-30 10:04 ` Daniel Lezcano [this message]
[not found] ` <CAKohponOKk5e2Sxyhjw-XvzVxF3tNp66rsnYCwvwHazAPAauKw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-07 3:50 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508FA649.6090901@linaro.org \
--to=daniel.lezcano@linaro$(echo .)org \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linaro-dev@lists$(echo .)linaro.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=patches@linaro$(echo .)org \
--cc=viresh.kumar@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox