public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Chris J Arges <chris.j.arges@canonical•com>
To: netdev@vger•kernel.org
Cc: Andy Gospodarek <andy@greyhouse•net>
Subject: [PATCH] bonding: extend bond_arp_send_all to bridge devices
Date: Tue, 30 Oct 2012 18:07:45 +0100	[thread overview]
Message-ID: <50900961.7010907@canonical.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 308 bytes --]

Hi, please accept this patch that fixes the following issues:
http://bugzilla.kernel.org/show_bug.cgi?id=31822
http://launchpad.net/bugs/736226

I've done a bit of testing with the setup identified in the bugs, and
this patch fixes the issue for me and others that have tested this.

Thanks,
--chris j arges

[-- Attachment #2: 0001-bonding-extend-bond_arp_send_all-to-bridge-devices.patch --]
[-- Type: text/x-patch, Size: 1701 bytes --]

>From bc58ecc70aecc68497fe54228ebe8630777b53a0 Mon Sep 17 00:00:00 2001
From: Chris J Arges <chris.j.arges@canonical•com>
Date: Thu, 6 Sep 2012 14:17:40 -0500
Subject: [PATCH] bonding: extend bond_arp_send_all to bridge devices

ARP monitoring does not work when we have a network in the
following configuration:

eth0----+ +----bond0.100----br0-100---{+virtual machines
          | |
          +----bond0----+----br0---(fixed IP)->--{LAN arp_ip_target}
          | |
eth1----+ +----bond0.200----br0-200---{+virtual machines

This patch extends bond_arp_send_all to also check if a device
is also in a bridge.

This is related to the following issues:
http://launchpad.net/bugs/736226
http://bugzilla.kernel.org/show_bug.cgi?id=31822

Thanks to help from Andy Gospodarek.

Signed-off-by: Chris J Arges <chris.j.arges@canonical•com>
---
 drivers/net/bonding/bond_main.c |   12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index b2530b0..cb791f6 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -2708,6 +2708,18 @@ static void bond_arp_send_all(struct bonding *bond, struct slave *slave)
 			continue;
 		}
 
+		/*
+		 * Check if the target is part of a bridge.
+		 */
+		if (rt->dst.dev->priv_flags & IFF_EBRIDGE) {
+			/* Confirm addr is part of the bridge */
+			addr = bond_confirm_addr(rt->dst.dev, targets[i], 0);
+
+			/* Send ARP request */
+			bond_arp_send(slave->dev, ARPOP_REQUEST, targets[i], addr, 0);
+			continue;
+		}
+
 		if (net_ratelimit()) {
 			pr_warning("%s: no path to arp_ip_target %pI4 via rt.dev %s\n",
 				   bond->dev->name, &targets[i],
-- 
1.7.10.4

next             reply	other threads:[~2012-10-30 17:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-30 17:07 Chris J Arges [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-11-05 20:14 [PATCH] bonding: extend bond_arp_send_all to bridge devices Chris J Arges

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:b2530b0 dfblob:cb791f6 )
 OR (
bs:"bonding: extend bond_arp_send_all to bridge devices" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50900961.7010907@canonical.com \
    --to=chris.j.arges@canonical$(echo .)com \
    --cc=andy@greyhouse$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox