From: Chen Gang <gang.chen@asianux•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: "linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
netdev <netdev@vger•kernel.org>
Subject: Re: [Suggestion] net-ipv6: format %8s change to %16s in rt6_info_route function of route.c
Date: Thu, 01 Nov 2012 18:23:47 +0800 [thread overview]
Message-ID: <50924DB3.9010601@asianux.com> (raw)
In-Reply-To: <1351760482.32673.913.camel@edumazet-glaptop>
于 2012年11月01日 17:01, Eric Dumazet 写道:
> Hi Chen
>
> Thats a good suggestion indeed.
>
thank you very much for your confirmation.
> Networking patches should be sent to netdev@vger•kernel.org (added in
> CC)
I will do it.
>
> This list only cares about recent generic kernels, not RedHat ones.
>
it seems "it is not suitable to send any issues which only relative
with Red Hat to linux-*@vger.kernel.org".
> If you want to provide a patch, please base it on David Miller net-next
> [1] tree, and make it official (read Documentation/SubmittingPatches for
> general advices)
>
ok, I will follow, thank you for your information.
> By the way, the %8s should be replaced by %s, there is no need to make
> /proc/net/ipv6_route 'beautiful'. In the past, it was *needed* because
> each line had to be of a given length, but its not anymore the case.
>
> Thanks
>
1) I agree with your result.
2) But for the "reason", I have my opinions:
A) %.8s : for limitation of output string length.
B) %8s : for width of output string length (but not limit 8).
C) %8.8s: both limitation and width.
3) for rt->rt6i_dev->name:
A) original %8s is not a bug for name len is more than 8 (can still
be outputted correctly)
B) it is only effect with name len is less than 8 (it will fill some
' ' before the name)
C) this is the reason why I call it "beautiful", not a bug.
> [1] :
> http://git.kernel.org/?p=linux/kernel/git/davem/net-next.git;a=summary
>
I will reference it, thanks.
--
Chen Gang
Asianux Corporation
prev parent reply other threads:[~2012-11-01 10:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <50921A92.8000809@asianux.com>
2012-11-01 9:01 ` [Suggestion] net-ipv6: format %8s change to %16s in rt6_info_route function of route.c Eric Dumazet
2012-11-01 10:23 ` Chen Gang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50924DB3.9010601@asianux.com \
--to=gang.chen@asianux$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox