From: Andrew Gallatin <gallatin@myri•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: netdev <netdev@vger•kernel.org>
Subject: Re: gro vs vlan in myri10ge
Date: Fri, 09 Nov 2012 07:47:02 -0500 [thread overview]
Message-ID: <509CFB46.30501@myri.com> (raw)
In-Reply-To: <1352428870.19779.496.camel@edumazet-glaptop>
On 11/08/12 21:41, Eric Dumazet wrote:
> On Thu, 2012-11-08 at 21:20 -0500, Andrew Gallatin wrote:
<...>
>> Is this (popping vlan tags in the driver) acceptable, or is it
>> too much of a layering violation?
>
> Given GRO assumes NIC does hardware vlan offloading, I guess
> I would chose to do that.
>
> It seems unfortunate to add vlan decap in GRO path, already very
> complex.
OK, then I will prepare & run through q/a a real patch that does this.
Thanks again,
Drew
next prev parent reply other threads:[~2012-11-09 12:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 2:20 gro vs vlan in myri10ge Andrew Gallatin
2012-11-09 2:41 ` Eric Dumazet
2012-11-09 12:47 ` Andrew Gallatin [this message]
2012-11-15 20:39 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509CFB46.30501@myri.com \
--to=gallatin@myri$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox