From: Ben Greear <greearb@candelatech•com>
To: Jan Engelhardt <jengelh@inai•de>
Cc: David Miller <davem@davemloft•net>,
paulius.zaleckas@gmail•com, kaber@trash•net,
netdev@vger•kernel.org
Subject: Re: [PATCH] vlan: Make it possible to add vlan with id 4095
Date: Mon, 12 Nov 2012 11:01:21 -0800 [thread overview]
Message-ID: <50A14781.1030106@candelatech.com> (raw)
In-Reply-To: <alpine.LNX.2.01.1211121941370.1611@nerf07.vanv.qr>
On 11/12/2012 10:42 AM, Jan Engelhardt wrote:
> On Friday 2012-09-28 19:44, David Miller wrote:
>
>> From: Paulius Zaleckas <paulius.zaleckas@gmail•com>
>> Date: Fri, 28 Sep 2012 15:32:58 +0300
>>
>>> vconfig help tells that vlan_id should be 0-4095, but fails
>>> with 4095.
>>>
>>> There is an off-by-one bug while evaluating vlan_id.
>>> Fix it by evaluating against count(4096), not mask(0x0fff = 4095).
>>>
>>> Signed-off-by: Paulius Zaleckas <paulius.zaleckas@gmail•com>
>>
>> Awesome, we don't need VXVLAN any more after this fix.
>
> You mean because the special 0xfff value could indicate "here's more
> headers"? Sounds like a plan.
You can't just use reserved values...they are for the standards writers
in case they ever need to officially extend the 802.1q spec somehow.
If you use it for non-standard purposes, you can set up conflicts with
future standards.
Thanks,
Ben
--
Ben Greear <greearb@candelatech•com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2012-11-12 19:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 12:32 [PATCH] vlan: Make it possible to add vlan with id 4095 Paulius Zaleckas
2012-09-28 13:29 ` Paulius Zaleckas
2012-09-28 17:44 ` David Miller
2012-09-28 17:55 ` Eric Dumazet
2012-11-12 18:42 ` Jan Engelhardt
2012-11-12 19:01 ` Ben Greear [this message]
2012-11-12 20:37 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A14781.1030106@candelatech.com \
--to=greearb@candelatech$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jengelh@inai$(echo .)de \
--cc=kaber@trash$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paulius.zaleckas@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox