From: Andrew Gallatin <gallatin@myri•com>
To: David Miller <davem@davemloft•net>
Cc: eric.dumazet@gmail•com, bhutchings@solarflare•com,
netdev@vger•kernel.org, linux-net-drivers@solarflare•com,
herbert@gondor•hengli.com.au
Subject: Re: [PATCH net-next] gro: Handle inline VLAN tags
Date: Mon, 26 Nov 2012 10:04:44 -0500 [thread overview]
Message-ID: <50B3850C.4070902@myri.com> (raw)
In-Reply-To: <20121119.191002.1995098917961576324.davem@davemloft.net>
On 11/19/12 19:10, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail•com>
> Date: Fri, 16 Nov 2012 17:09:19 -0800
>
>> On Sat, 2012-11-17 at 00:32 +0000, Ben Hutchings wrote:
>>> On Fri, 2012-11-16 at 16:16 -0800, Eric Dumazet wrote:
>>>> On Sat, 2012-11-17 at 00:00 +0000, Ben Hutchings wrote:
>>>>
>>>>> I'm not sure what you mean by this. Is your point that the
>>>>> copy-on-write is never needed? It is still possible for pskb_may_pull()
>>>>> to fail.
>>>>>
>>>>
>>>> A packet sniffer should have a copy of bad frames, even if dropped later
>>>> in our stacks.
>>>>
>>>> GRO layer is not allowed to drop a frame, even if not 'correct'.
>>>
>>> What do you think the accelerated hardware does with frames that have a
>>> truncated VLAN tag?
>>
>> The hardware should send us the frame, exactly like when RX checksum is
>> wrong.
>
> I agree with Eric, and therefore will not apply this patch.
>
David,
How do you feel about the patchset I posted on 11/14/2012
([PATCH net-next 0/3] myri10ge: LRO to GRO conversion,
http://marc.info/?l=linux-netdev&m=135289838223920&w=2)
which moves myri10ge from LRO to GRO?
Specifically, if doing vlan decap in GRO is not OK, then how
about doing it in the driver?
BTW, if I have bungled something it the myri10ge patchset submission,
I do apologize. I don't frequently submit patches, and it is likely
I screwed up some convention..
Thanks,
Drew
next prev parent reply other threads:[~2012-11-26 15:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 20:17 [PATCH net-next] gro: Handle inline VLAN tags Ben Hutchings
2012-11-16 23:01 ` Eric Dumazet
2012-11-17 0:00 ` Ben Hutchings
2012-11-17 0:16 ` Eric Dumazet
2012-11-17 0:32 ` Ben Hutchings
2012-11-17 1:09 ` Eric Dumazet
2012-11-20 0:10 ` David Miller
2012-11-26 15:04 ` Andrew Gallatin [this message]
2012-11-28 16:46 ` David Miller
2012-11-28 17:30 ` Andrew Gallatin
2012-11-28 18:39 ` David Miller
2012-11-17 1:17 ` Andrew Gallatin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B3850C.4070902@myri.com \
--to=gallatin@myri$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=herbert@gondor$(echo .)hengli.com.au \
--cc=linux-net-drivers@solarflare$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox