From: Or Gerlitz <ogerlitz@mellanox•com>
To: David Howells <dhowells@redhat•com>
Cc: Or Gerlitz <or.gerlitz@gmail•com>, netdev <netdev@vger•kernel.org>
Subject: Re: private netdev flags into UAPI?
Date: Tue, 27 Nov 2012 08:51:28 +0200 [thread overview]
Message-ID: <50B462F0.1070506@mellanox.com> (raw)
In-Reply-To: <990.1353981789@warthog.procyon.org.uk>
On 27/11/2012 04:03, David Howells wrote:
> Or Gerlitz <or.gerlitz@gmail•com> wrote:
>
>> On Mon, Nov 26, 2012 at 11:22 AM, David Howells <dhowells@redhat•com> wrote:
>>> They were exposed to userspace already
>> So the script carries the bug into a new directory... why? AFAIK,
>> intentionally there's no way to read private flags from user space, so
>> what's the point in defining them there?
> How should the script know what's private and what's not? By the
> encapsulation of code inside __KERNEL__ blocks. In their absence, everything
> is assumed to be public - given it is already part of the UAPI. I don't know
> that the code is private rather than the comment is wrong.
>
>
makes sense, but I have pointed on a bug in the final result, so this
way or another, the fact that the bug
existed before doesn't mean we should carry it over.
Or.
prev parent reply other threads:[~2012-11-27 6:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-25 7:43 private netdev flags into UAPI? Or Gerlitz
2012-11-26 9:22 ` David Howells
2012-11-26 22:29 ` Or Gerlitz
2012-11-27 2:03 ` David Howells
2012-11-27 6:51 ` Or Gerlitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B462F0.1070506@mellanox.com \
--to=ogerlitz@mellanox$(echo .)com \
--cc=dhowells@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=or.gerlitz@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox