From: Chen Gang <gang.chen@asianux•com>
To: Shan Wei <shanwei88@gmail•com>
Cc: Eric Dumazet <eric.dumazet@gmail•com>,
David Miller <davem@davemloft•net>,
netdev <netdev@vger•kernel.org>
Subject: Re: Fwd: Re: [PATCH] net: ipv6: change %8s to %s for rt->dst.dev->name in seq_printf of rt6_info_route
Date: Wed, 28 Nov 2012 13:54:53 +0800 [thread overview]
Message-ID: <50B5A72D.6070107@asianux.com> (raw)
In-Reply-To: <50B4551C.6030505@asianux.com>
completion: "8 right alignment should not belong to os api level"
for api, we need keep as fewer contents as we can.
for output format api: "contents"+"topology"+"separator mark"+"space redundancy" are enough.
so "8 right alignment" should not belong to api level (it only belongs to "User Experience").
"User Experience" is most likely 'beautiful' !!
!-)
gchen.
于 2012年11月27日 13:52, Chen Gang 写道:
> 于 2012年11月27日 13:40, Chen Gang 写道:
>>
>> and now, I think:
>> A) both input and output through /proc/* are for os api level.
>> B) but both %8s and %s do not change the output interface format (including contents, topology, separator mark, space redundancy).
>> C) so it is belong to 'User Experience', not belong to os api.
>>
>> welcome any another members to giving suggestions and completions.
>>
>> thanks.
>>
>> :-)
>>
>
> completion: 8 right alignment is not belong to interface format.
> if it was belong to interface format,
> it would cause correctness issue (the name len may be larger than 8).
> so if "8 right alignment" is belong to os api, it means the api is not correct, need change.
>
> :-)
>
--
Chen Gang
Asianux Corporation
next prev parent reply other threads:[~2012-11-28 5:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 2:52 [PATCH] net: ipv6: change %8s to %s for rt->dst.dev->name in seq_printf of rt6_info_route Chen Gang
2012-11-22 5:28 ` Shan Wei
2012-11-22 8:37 ` Chen Gang
2012-11-23 3:35 ` Fwd: " Chen Gang
2012-11-27 3:17 ` Shan Wei
2012-11-27 4:18 ` Chen Gang
2012-11-27 4:45 ` Chen Gang
2012-11-27 5:40 ` Chen Gang
2012-11-27 5:52 ` Chen Gang
2012-11-28 5:54 ` Chen Gang [this message]
2012-11-27 4:56 ` Shan Wei
2012-11-27 5:35 ` Chen Gang
2012-11-29 1:43 ` [Consult] excuse me: sorry for the negative effects which I made Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B5A72D.6070107@asianux.com \
--to=gang.chen@asianux$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shanwei88@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox