public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Chen Gang <gang.chen@asianux•com>
To: chas williams - CONTRACTOR <chas@cmf•nrl.navy.mil>
Cc: David Miller <davem@davemloft•net>, netdev <netdev@vger•kernel.org>
Subject: Re: [Suggestion] net/atm : for sprintf, need check the total write length whether larger than a page.
Date: Fri, 07 Dec 2012 09:07:40 +0800	[thread overview]
Message-ID: <50C1415C.2060104@asianux.com> (raw)
In-Reply-To: <20121206090855.5f166746@thirdoffive.cmf.nrl.navy.mil>

于 2012年12月06日 22:08, chas williams - CONTRACTOR 写道:
> On Thu, 06 Dec 2012 09:15:10 +0800
> Chen Gang <gang.chen@asianux•com> wrote:
> 
>> 于 2012年12月05日 22:55, chas williams - CONTRACTOR 写道:
> 
>>> did you mean '\0' instead of '\n'?  scnprintf() considers the trailing
>>> '\0' when formatting.
>>
>>   no, originally, the end is "\n\0".
>>
>>   I prefer we still compatible "\n" when the contents are very large.
>>   if count already == (PAGE_SIZE - 1), we have no chance to append "\n" to the end.
>>
>> -		pos += sprintf(pos, "\n");
>> +		count += scnprintf(buf + count, PAGE_SIZE - count, "\n");
> 
> i would make the code a bit messy to do this for not much gain.  again,
> it isnt likely you would run into this in a normal situation.

  surely.

  thanks.

> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 


-- 
Chen Gang

Asianux Corporation

next prev parent reply	other threads:[~2012-12-07  1:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-21  4:29 [Suggestion] net/atm : for sprintf, need check the total write length whether larger than a page Chen Gang
2012-12-03  8:56 ` Chen Gang
2012-12-03 15:48   ` chas williams - CONTRACTOR
2012-12-05  1:28     ` Chen Gang
2012-12-04  3:46 ` Chas Williams (CONTRACTOR)
2012-12-05  1:26   ` Chen Gang
2012-12-05  3:57     ` Chas Williams (CONTRACTOR)
2012-12-05  4:56       ` Chen Gang
2012-12-05  5:40         ` Chen Gang
2012-12-05  5:59           ` Chen Gang
2012-12-05 14:55             ` chas williams - CONTRACTOR
2012-12-06  1:15               ` Chen Gang
2012-12-06  9:05                 ` Chen Gang
2012-12-06 14:08                 ` chas williams - CONTRACTOR
2012-12-07  1:07                   ` Chen Gang [this message]
2012-12-10  1:39                     ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50C1415C.2060104@asianux.com \
    --to=gang.chen@asianux$(echo .)com \
    --cc=chas@cmf$(echo .)nrl.navy.mil \
    --cc=davem@davemloft$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox