From: Vipul Pandya <vipul@chelsio•com>
To: David Miller <davem@davemloft•net>
Cc: "linux-rdma@vger•kernel.org" <linux-rdma@vger•kernel.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"roland@purestorage•com" <roland@purestorage•com>,
Divy Le Ray <divy@chelsio•com>,
Dimitrios Michailidis <dm@chelsio•com>,
Kumar A S <kumaras@chelsio•com>,
Steve Wise <swise@opengridcomputing•com>,
Abhishek Agrawal <abhishek@chelsio•com>
Subject: Re: [PATCH V3 1/5] cxgb4: Add T4 filter support
Date: Mon, 10 Dec 2012 15:16:23 +0530 [thread overview]
Message-ID: <50C5AF6F.6080502@chelsio.com> (raw)
In-Reply-To: <20121203.140207.164096621247746195.davem@davemloft.net>
On 04-12-2012 00:32, David Miller wrote:
> From: Vipul Pandya <vipul@chelsio•com>
> Date: Mon, 3 Dec 2012 16:52:57 +0530
>
>> + /*
>> + * If the new or old filter have loopback rewriteing rules then we'll
>> + * need to free any existing Layer Two Table (L2T) entries of the old
>> + * filter rule. The firmware will handle freeing up any Source MAC
>> + * Table (SMT) entries used for rewriting Source MAC Addresses in
>> + * loopback rules.
>> + */
>> + if (f->l2t)
>> + cxgb4_l2t_release(f->l2t);
>> +
>> + /* The zeroing of the filter rule below clears the filter valid,
>> + * pending, locked flags, l2t pointer, etc. so it's all we need for
>> + * this operation.
>> + */
>
> My greatest amusement is achieved when someone gets a code formatting
> rule both correct and wrong in the same patch, as you have done here.
>
> Format comments in the networking:
>
> /* Like
> * this.
> */
>
> /*
> * Never,
> * like this.
> */
>
> Thanks.
>
I have submitted the series again making above changes. Thanks for
pointing out the same. I wonder how checkpatch.pl did not complain or
gave a warning for the incorrect commenting style. I corrected only
those comments for which checkpatch.pl gave me a warning. So, I think
there are some checks missing in checkpatch.pl script.
Thanks,
Vipul
next prev parent reply other threads:[~2012-12-10 9:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 11:22 [PATCH V3 0/5] Add LE hash collision bug fix for active and passive offloaded connections Vipul Pandya
[not found] ` <1354533781-31575-1-git-send-email-vipul-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2012-12-03 11:22 ` [PATCH V3 1/5] cxgb4: Add T4 filter support Vipul Pandya
[not found] ` <1354533781-31575-2-git-send-email-vipul-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2012-12-03 19:02 ` David Miller
2012-12-10 9:46 ` Vipul Pandya [this message]
2012-12-03 11:22 ` [PATCH V3 2/5] cxgb4: Add LE hash collision bug fix path in LLD driver Vipul Pandya
2012-12-03 11:22 ` [PATCH V3 3/5] RDMA/cxgb4: Fix LE hash collision bug for active open connection Vipul Pandya
2012-12-03 11:23 ` [PATCH V3 4/5] RDMA/cxgb4: Fix LE hash collision bug for passive " Vipul Pandya
2012-12-03 11:23 ` [PATCH V3 5/5] RDMA/cxgb4: Fix bug for active and passive LE hash collision path Vipul Pandya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C5AF6F.6080502@chelsio.com \
--to=vipul@chelsio$(echo .)com \
--cc=abhishek@chelsio$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=divy@chelsio$(echo .)com \
--cc=dm@chelsio$(echo .)com \
--cc=kumaras@chelsio$(echo .)com \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=roland@purestorage$(echo .)com \
--cc=swise@opengridcomputing$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox