Subject: Re: [PATCH] Fix comment for packets without data

From: Rick Jones <[email-masked]>
Date: Thu, 13 Dec 2012 10:51:22 -0800

On 12/13/2012 10:27 AM, Florent Fourcot wrote:
> The double negation is probably a typo error
>
> Signed-off-by: Florent Fourcot <[email-masked]>
> ---
>   net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c b/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c
> index 00ee17c..d9efe32 100644
> --- a/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c
> +++ b/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c
> @@ -81,7 +81,7 @@ static int ipv6_get_l4proto(const struct sk_buff *skb, unsigned int nhoff,
>   	}
>   	protoff = ipv6_skip_exthdr(skb, extoff, &nexthdr, &frag_off);
>   	/*
> -	 * (protoff == skb->len) mean that the packet doesn't have no data
> +	 * (protoff == skb->len) mean that the packet does not have any data
>   	 * except of IPv6 & ext headers. but it's tracked anyway. - YK
>   	 */
>   	if (protoff < 0 || (frag_off & htons(~0x7)) != 0) {
>

Might as well take it to completion and have it read "(protoff == 
skb->len) means the packet does not have any data"  or "(protoff == 
skb->len) means the packet has no data"  Not sure about that next line 
with the except.  Perhaps "(protoff == skb->len) means the packet has no 
data, just IPv6 and extension headers, but it is tracked anyway."

rick jones