From: Ang Way Chuang <wcang@sfc•wide.ad.jp>
To: netdev@vger•kernel.org
Cc: Stephen Hemminger <shemminger@vyatta•com>,
bridge@lists•linux-foundation.org
Subject: [PATCH] bridge: Bug fix for incorrect interpretation of MLDv2 maximum response code
Date: Fri, 14 Dec 2012 08:07:01 +0800 [thread overview]
Message-ID: <50CA6DA5.1020101@sfc.wide.ad.jp> (raw)
This patch fixes the incorrect interpretation of endianness of MLDv2 maximum response
code within bridge's multicast snooping code.
Signed-off-by: Ang Way Chuang <wcang@sfc•wide.ad.jp>
---
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index 977c3ee..29c6283 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -1172,7 +1172,7 @@ static int br_ip6_multicast_query(struct net_bridge *br,
mld2q = (struct mld2_query *)icmp6_hdr(skb);
if (!mld2q->mld2q_nsrcs)
group = &mld2q->mld2q_mca;
- max_delay = mld2q->mld2q_mrc ? MLDV2_MRC(mld2q->mld2q_mrc) : 1;
+ max_delay = mld2q->mld2q_mrc ? MLDV2_MRC(ntohs(mld2q->mld2q_mrc)) : 1;
}
if (!group)
next reply other threads:[~2012-12-14 0:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 0:07 Ang Way Chuang [this message]
2012-12-14 0:12 ` [PATCH] bridge: Bug fix for incorrect interpretation of MLDv2 maximum response code Stephen Hemminger
2012-12-14 0:19 ` Ang Way Chuang
2012-12-14 0:23 ` Stephen Hemminger
2012-12-14 0:35 ` Ang Way Chuang
2012-12-14 0:51 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CA6DA5.1020101@sfc.wide.ad.jp \
--to=wcang@sfc$(echo .)wide.ad.jp \
--cc=bridge@lists$(echo .)linux-foundation.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox