Subject: Re: [PATCH net] sctp: jsctp_sf_eat_sack: fix jprobes function signature mismatch

From: Vlad Yasevich <[email-masked]>
Date: Sat, 15 Dec 2012 15:39:51 -0500

On 12/15/2012 03:12 PM, Daniel Borkmann wrote:
> Commit 24cb81a6a (sctp: Push struct net down into all of the
> state machine functions) introduced the net structure into all
> state machine functions, but jsctp_sf_eat_sack was not updated,
> hence when SCTP association probing is enabled in the kernel,
> any simple SCTP client/server program from userspace will panic
> the kernel.

Aha!!!  That makes a lot more sense...

Acked-by: Vlad Yasevich <[email-masked]>

Thanks
-vlad

>
> Cc: Vlad Yasevich <[email-masked]>
> Signed-off-by: Daniel Borkmann <[email-masked]>
> ---
>   net/sctp/probe.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/sctp/probe.c b/net/sctp/probe.c
> index bc6cd75..5f7518d 100644
> --- a/net/sctp/probe.c
> +++ b/net/sctp/probe.c
> @@ -122,7 +122,8 @@ static const struct file_operations sctpprobe_fops = {
>   	.llseek = noop_llseek,
>   };
>
> -sctp_disposition_t jsctp_sf_eat_sack(const struct sctp_endpoint *ep,
> +sctp_disposition_t jsctp_sf_eat_sack(struct net *net,
> +				     const struct sctp_endpoint *ep,
>   				     const struct sctp_association *asoc,
>   				     const sctp_subtype_t type,
>   				     void *arg,
>